view tests/test-mq-qimport-fail-cleanup.t @ 50942:75d3306fbc9a stable

tags: avoid expensive access to repo.changelog in a loop

repo.changelog needs some cache invalidation when run on filtered repository.
Accessing it in that loop can be expensive when there is many heads (e.g.
mozilla try and it 25 000 heads).

Note that the loop itself seems useless, but after this patch it no longer take
about ⅛  of the time we spend computing cache for mozilla try.

before :
! wall 0.350994 comb 0.350000 user 0.330000 sys 0.020000 (median of 28)

after :
! wall 0.319520 comb 0.310000 user 0.290000 sys 0.020000 (median of 30)

Failed qimport of patches from files should cleanup by recording successfully
imported patches in series file.

  $ echo "[extensions]" >> $HGRCPATH
  $ echo "mq=" >> $HGRCPATH
  $ hg init repo
  $ cd repo
  $ echo a > a
  $ hg ci -Am'add a'
  adding a
  $ cat >b.patch<<EOF
  > diff --git a/a b/a
  > --- a/a
  > +++ b/a
  > @@ -1,1 +1,2 @@
  >  a
  > +b
  > EOF

empty series

  $ hg qseries

qimport valid patch followed by invalid patch

  $ hg qimport b.patch fakepatch
  adding b.patch to series file
  abort: unable to read file fakepatch
  [255]

valid patches before fail added to series

  $ hg qseries
  b.patch

  $ hg pull -q -r 0 . # update phase
  $ hg qimport -r 0
  abort: revision 0 is not mutable
  (see 'hg help phases' for details)
  [255]

  $ cd ..