view CONTRIBUTING @ 49543:76fbb1b6692a stable

keepalive: add `__repr__()` to the HTTPConnection class to ease debugging

By default, this just printed the class name and memory address.  By displaying
the address and ports on both sides of the socket, it makes it easier to figure
out what's in the ConnectionManager, and correlate with WireShark traces.

It looks like the two connections mentioned in the previous commit come about
because the LFS POST request to access the blobs opens connection 1, and gets a
401.  Then for some reason, the follow up with credentials opens a new socket,
instead of using the existing one in the pool.  I have no clue why.

This can be seen with something like this in the blobstore:

```
    for h in self.urlopener.handlers:
        if hasattr(h, "close_all"):
            print('open connections on %s in pid %d' % (type(h), os.getpid()))
            for host, conns in h._cm.get_all().items():
                for c in conns:
                    print('connection: %r' % c)
```

Our full contribution guidelines are in our wiki, please see:

https://www.mercurial-scm.org/wiki/ContributingChanges

If you just want a checklist to follow, you can go straight to

https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist

If you can't run the entire testsuite for some reason (it can be
difficult on Windows), please at least run `contrib/check-code.py` on
any files you've modified and run `python contrib/check-commit` on any
commits you've made (for example, `python contrib/check-commit
273ce12ad8f1` will report some style violations on a very old commit).