mercurial/cacheutil.py

subrepo: fix a crash when archiving an svn or git subrepo

Only hgsubrepos have a repository attribute.  This is pretty hacky, but probably
the best we can do on stable.  Pushing the lfstatus check down into the wrapper
for hgsubrepo (and dropping the check for lfstatus at the top of
`hgsubrepoarchive()`) resulted in various test failures because:

  1) hgsubrepoarchive isn't returning the number of files archived at the
     bottom, resulting in an error about += NoneType
  2) These copypasta archive wrappers don't use progress bars
  3) Largefiles are *not* currently archived when using extdiff (68822b7cdd01),
     but pushing this context manager down into the subrepo resulted in it
     apparently doing so (as evidenced by progress bars being dropped)

The other uses of `lfstatus()` are not in the substate processing loop, so they
shouldn't be an issue.

I initially put testcases in this test for largefiles-{on,off}, and it flagged
a bunch of exit code differences for `cat` and `diff`, so I backed that off.

Differential Revision: https://phab.mercurial-scm.org/D7714

# scmutil.py - Mercurial core utility functions
#
#  Copyright Matt Mackall <[e-mail]> and other
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
from __future__ import absolute_import

from . import repoview


def cachetocopy(srcrepo):
    """return the list of cache file valuable to copy during a clone"""
    # In local clones we're copying all nodes, not just served
    # ones. Therefore copy all branch caches over.
    cachefiles = [b'branch2']
    cachefiles += [b'branch2-%s' % f for f in repoview.filtertable]
    cachefiles += [b'rbc-names-v1', b'rbc-revs-v1']
    cachefiles += [b'tags2']
    cachefiles += [b'tags2-%s' % f for f in repoview.filtertable]
    cachefiles += [b'hgtagsfnodes1']
    return cachefiles