Mercurial > hg
view tests/blacklists/linux-vfat @ 39548:7ce9dea3a14a
localrepo: move repo creation logic out of localrepository.__init__ (API)
It has long bothered me that local repository creation is handled as
part of localrepository.__init__. Upcoming changes I want to make
around how repositories are initialized and instantiated will make
the continued existence of repository creation code in
localrepository.__init__ even more awkward.
localrepository instances are almost never constructed directly:
instead, callers are supposed to go through hg.repository() to obtain
a handle on a repository. And hg.repository() calls
localrepo.instance() to return a new repo instance.
This commit teaches localrepo.instance() to handle the create=True
logic. Most of the code for repo construction has been moved to a
standalone function. This allows extensions to monkeypatch the function
to further customize freshly-created repositories.
A few calls to localrepo.localrepository.__init__ that were passing
create=True were converted to call localrepo.instance().
.. api:: local repo creation moved out of constructor
``localrepo.localrepository.__init__`` no longer accepts a
``create`` argument to create a new repository. New repository
creation is now performed as part of ``localrepo.instance()``
and the bulk of the work is performed by
``localrepo.createrepository()``.
Differential Revision: https://phab.mercurial-scm.org/D4534
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Tue, 11 Sep 2018 13:46:59 -0700 |
parents | 352abbb0be88 |
children |
line wrap: on
line source
# invalid filenames test-add.t test-init.t test-clone.t test-contrib.t test-hgweb-raw.t test-walk.t # no sockets or fifos test-hup.t # no hardlinks test-hardlinks.t test-relink.t # exec bit problems test-convert-bzr-114.t test-convert-bzr-directories.t test-convert-bzr-merges.t test-convert-bzr-treeroot.t test-convert-darcs.t test-merge-tools.t # debugstate exec bit false positives test-dirstate.t test-filebranch.t test-merge-remove.t