Mercurial > hg
view tests/test-sparse-fsmonitor.t @ 39548:7ce9dea3a14a
localrepo: move repo creation logic out of localrepository.__init__ (API)
It has long bothered me that local repository creation is handled as
part of localrepository.__init__. Upcoming changes I want to make
around how repositories are initialized and instantiated will make
the continued existence of repository creation code in
localrepository.__init__ even more awkward.
localrepository instances are almost never constructed directly:
instead, callers are supposed to go through hg.repository() to obtain
a handle on a repository. And hg.repository() calls
localrepo.instance() to return a new repo instance.
This commit teaches localrepo.instance() to handle the create=True
logic. Most of the code for repo construction has been moved to a
standalone function. This allows extensions to monkeypatch the function
to further customize freshly-created repositories.
A few calls to localrepo.localrepository.__init__ that were passing
create=True were converted to call localrepo.instance().
.. api:: local repo creation moved out of constructor
``localrepo.localrepository.__init__`` no longer accepts a
``create`` argument to create a new repository. New repository
creation is now performed as part of ``localrepo.instance()``
and the bulk of the work is performed by
``localrepo.createrepository()``.
Differential Revision: https://phab.mercurial-scm.org/D4534
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Tue, 11 Sep 2018 13:46:59 -0700 |
parents | abd7dedbaa36 |
children |
line wrap: on
line source
This test doesn't yet work due to the way fsmonitor is integrated with test runner $ exit 80 test sparse interaction with other extensions $ hg init myrepo $ cd myrepo $ cat > .hg/hgrc <<EOF > [extensions] > sparse= > strip= > EOF Test fsmonitor integration (if available) TODO: make fully isolated integration test a'la https://github.com/facebook/watchman/blob/master/tests/integration/WatchmanInstance.py (this one is using the systemwide watchman instance) $ touch .watchmanconfig $ echo "ignoredir1/" >> .hgignore $ hg commit -Am ignoredir1 adding .hgignore $ echo "ignoredir2/" >> .hgignore $ hg commit -m ignoredir2 $ hg sparse --reset $ hg sparse -I ignoredir1 -I ignoredir2 -I dir1 $ mkdir ignoredir1 ignoredir2 dir1 $ touch ignoredir1/file ignoredir2/file dir1/file Run status twice to compensate for a condition in fsmonitor where it will check ignored files the second time it runs, regardless of previous state (ask @sid0) $ hg status --config extensions.fsmonitor= ? dir1/file $ hg status --config extensions.fsmonitor= ? dir1/file Test that fsmonitor ignore hash check updates when .hgignore changes $ hg up -q ".^" $ hg status --config extensions.fsmonitor= ? dir1/file ? ignoredir2/file