view tests/.balto.toml @ 45375:8c466bcb0879

revert: remove dangerous `parents` argument from `cmdutil.revert()`

As we found out the hard way (thanks to spectral@ for figuring it
out!), `cmdutil.revert()`'s `parents` argument must be
`repo.dirstate.parents()` or things may go wrong. We had an extension
that passed in the target commit as the first parent. The `hg split`
command from the evolve extension seems to have made the same mistake,
but I haven't looked carefully.

The problem is that `cmdutil._performrevert()` calls
`dirstate.normal()` on reverted files if the commit to revert to
equals the first parent. So if you pass in `ctx=foo` and
`parents=(foo.node(), nullid)`, then `dirstate.normal()` will be
called for the revert files, even though they might not be clean in
the working copy.

There doesn't seem to be any reason, other than a tiny performance
benefit, to passing the `parents` around instead of looking them up
again in `cmdutil._performrevert()`, so that's what this patch does.

Differential Revision: https://phab.mercurial-scm.org/D8925

# Balto (https://bitbucket.org/lothiraldan/balto/src) is a test orchestrator
# which is compatible with all test runner that can emit the LITF
# (https://github.com/lothiraldan/litf) test format.

# The plugin for the Mercurial test runner is mercurial-litf
# (https://pypi.org/project/mercurial-litf/). Make sure to follow the
# instruction and configuration instructions here:
# https://bitbucket.org/lothiraldan/mercurial_litf/src/default/

# You can launch Balto with `balto /path/to/mercurial/tests/`

name = "Mercurial Test Suite"
tool = "mercurial"