Mercurial > hg
view tests/test-debugbackupbundle.t @ 45375:8c466bcb0879
revert: remove dangerous `parents` argument from `cmdutil.revert()`
As we found out the hard way (thanks to spectral@ for figuring it
out!), `cmdutil.revert()`'s `parents` argument must be
`repo.dirstate.parents()` or things may go wrong. We had an extension
that passed in the target commit as the first parent. The `hg split`
command from the evolve extension seems to have made the same mistake,
but I haven't looked carefully.
The problem is that `cmdutil._performrevert()` calls
`dirstate.normal()` on reverted files if the commit to revert to
equals the first parent. So if you pass in `ctx=foo` and
`parents=(foo.node(), nullid)`, then `dirstate.normal()` will be
called for the revert files, even though they might not be clean in
the working copy.
There doesn't seem to be any reason, other than a tiny performance
benefit, to passing the `parents` around instead of looking them up
again in `cmdutil._performrevert()`, so that's what this patch does.
Differential Revision: https://phab.mercurial-scm.org/D8925
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Mon, 10 Aug 2020 21:46:47 -0700 |
parents | 20d74eebe56c |
children |
line wrap: on
line source
$ cat >> $HGRCPATH << EOF > [extensions] > strip= > EOF Setup repo $ hg init repo $ cd repo Test backups list and recover $ hg debugbackupbundle no backup changesets found $ mkcommit() { > echo "$1" > "$1" > hg add "$1" > hg ci -l $1 > } $ mkcommit a $ mkcommit b $ hg strip . 0 files updated, 0 files merged, 1 files removed, 0 files unresolved saved backup bundle to $TESTTMP/repo/.hg/strip-backup/d2ae7f538514-2953539b-backup.hg $ hg debugbackupbundle Recover changesets using: hg debugbackupbundle --recover <changeset hash> Available backup changesets: * (glob) d2ae7f538514 b $ hg debugbackupbundle --recover d2ae7f538514 Unbundling d2ae7f538514 adding changesets adding manifests adding file changes added 1 changesets with 1 changes to 1 files new changesets d2ae7f538514 (1 drafts)