view CONTRIBUTING @ 36803:8e1556ac01bb

hgweb: validate WSGI environment dict

The wsgiref.validate module contains useful functions for validating
that various WSGI data structures are proper.

This commit adds validation of the environment dict to our built-in
HTTP server, which turns an HTTP request into an environment dict.

The check discovered that we weren't always setting QUERY_STRING,
which would cause the cgi module to fall back to sys.argv. So we
change things to always set QUERY_STRING.

The check passes on Python 2 and 3.

Differential Revision: https://phab.mercurial-scm.org/D2731

Our full contribution guidelines are in our wiki, please see:

https://www.mercurial-scm.org/wiki/ContributingChanges

If you just want a checklist to follow, you can go straight to

https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist

If you can't run the entire testsuite for some reason (it can be
difficult on Windows), please at least run `contrib/check-code.py` on
any files you've modified and run `python contrib/check-commit` on any
commits you've made (for example, `python contrib/check-commit
273ce12ad8f1` will report some style violations on a very old commit).