Mercurial > hg
view tests/check-gendoc @ 45825:8f07f5a9c3de
worker: raise exception instead of calling sys.exit() with child's code
When a worker process returns an error code, we would call
`sys.exit()` with that exit code on the main process. The `SystemExit`
exception would then get caught in `scmutil.callcatch()`, which would
return that error code. The comment there says "Commands shouldn't
sys.exit directly", which I agree with. This patch changes it so we
raise a specific exception when a worker fails so we can catch
instead. I think that means that `SystemExit` is now always an
internal error.
(I had earlier thought that this call to `sys.exit()` was from within
the child process until Matt Harbison made me look again, so thanks
for that!)
Differential Revision: https://phab.mercurial-scm.org/D9287
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Sat, 07 Nov 2020 21:50:28 -0800 |
parents | 69c99898a48f |
children |
line wrap: on
line source
#!/bin/sh HGENCODING=UTF-8 export HGENCODING echo ".. -*- coding: utf-8 -*-" > gendoc.txt echo "" >> gendoc.txt LANGUAGE=$1 "$PYTHON" "$TESTDIR/../doc/gendoc.py" >> gendoc.txt 2> /dev/null || exit echo "checking for parse errors" "$PYTHON" "$TESTDIR/../doc/docchecker" gendoc.txt "$PYTHON" "$TESTDIR/../doc/runrst" html gendoc.txt /dev/null