Mercurial > hg
view tests/remotefilelog-getflogheads.py @ 45825:8f07f5a9c3de
worker: raise exception instead of calling sys.exit() with child's code
When a worker process returns an error code, we would call
`sys.exit()` with that exit code on the main process. The `SystemExit`
exception would then get caught in `scmutil.callcatch()`, which would
return that error code. The comment there says "Commands shouldn't
sys.exit directly", which I agree with. This patch changes it so we
raise a specific exception when a worker fails so we can catch
instead. I think that means that `SystemExit` is now always an
internal error.
(I had earlier thought that this call to `sys.exit()` was from within
the child process until Matt Harbison made me look again, so thanks
for that!)
Differential Revision: https://phab.mercurial-scm.org/D9287
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Sat, 07 Nov 2020 21:50:28 -0800 |
parents | 2372284d9457 |
children | a4c19a162615 |
line wrap: on
line source
from __future__ import absolute_import from mercurial.i18n import _ from mercurial import ( hg, registrar, ) cmdtable = {} command = registrar.command(cmdtable) @command(b'getflogheads', [], b'path') def getflogheads(ui, repo, path): """ Extension printing a remotefilelog's heads Used for testing purpose """ dest = repo.ui.expandpath(b'default') peer = hg.peer(repo, {}, dest) flogheads = peer.x_rfl_getflogheads(path) if flogheads: for head in flogheads: ui.write(head + b'\n') else: ui.write(_(b'EMPTY\n'))