view tests/test-contrib-emacs.t @ 45825:8f07f5a9c3de

worker: raise exception instead of calling sys.exit() with child's code

When a worker process returns an error code, we would call
`sys.exit()` with that exit code on the main process. The `SystemExit`
exception would then get caught in `scmutil.callcatch()`, which would
return that error code. The comment there says "Commands shouldn't
sys.exit directly", which I agree with. This patch changes it so we
raise a specific exception when a worker fails so we can catch
instead. I think that means that `SystemExit` is now always an
internal error.

(I had earlier thought that this call to `sys.exit()` was from within
the child process until Matt Harbison made me look again, so thanks
for that!)

Differential Revision: https://phab.mercurial-scm.org/D9287

#require emacs
  $ emacs -q -no-site-file -batch -l $TESTDIR/../contrib/hg-test-mode.el \
  >  -f ert-run-tests-batch-and-exit
  Running 1 tests (*) (glob)
     passed  1/1  hg-test-mode--compilation-mode-support* (glob)
  
  Ran 1 tests, 1 results as expected* (glob)