Mercurial > hg
view tests/test-hashutil.py @ 45825:8f07f5a9c3de
worker: raise exception instead of calling sys.exit() with child's code
When a worker process returns an error code, we would call
`sys.exit()` with that exit code on the main process. The `SystemExit`
exception would then get caught in `scmutil.callcatch()`, which would
return that error code. The comment there says "Commands shouldn't
sys.exit directly", which I agree with. This patch changes it so we
raise a specific exception when a worker fails so we can catch
instead. I think that means that `SystemExit` is now always an
internal error.
(I had earlier thought that this call to `sys.exit()` was from within
the child process until Matt Harbison made me look again, so thanks
for that!)
Differential Revision: https://phab.mercurial-scm.org/D9287
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Sat, 07 Nov 2020 21:50:28 -0800 |
parents | dc9b53482689 |
children | 6000f5b25c9b |
line wrap: on
line source
# Tests to ensure that sha1dc.sha1 is exactly a drop-in for # hashlib.sha1 for our needs. from __future__ import absolute_import import hashlib import unittest import silenttestrunner try: from mercurial.thirdparty import sha1dc except ImportError: sha1dc = None class hashertestsbase(object): def test_basic_hash(self): h = self.hasher() h.update(b'foo') self.assertEqual( '0beec7b5ea3f0fdbc95d0dd47f3c5bc275da8a33', h.hexdigest() ) h.update(b'bar') self.assertEqual( '8843d7f92416211de9ebb963ff4ce28125932878', h.hexdigest() ) def test_copy_hasher(self): h = self.hasher() h.update(b'foo') h2 = h.copy() h.update(b'baz') h2.update(b'bar') self.assertEqual( '21eb6533733a5e4763acacd1d45a60c2e0e404e1', h.hexdigest() ) self.assertEqual( '8843d7f92416211de9ebb963ff4ce28125932878', h2.hexdigest() ) def test_init_hasher(self): h = self.hasher(b'initial string') self.assertEqual( b'\xc9y|n\x1f3S\xa4:\xbaJ\xca,\xc1\x1a\x9e\xb8\xd8\xdd\x86', h.digest(), ) def test_bytes_like_types(self): h = self.hasher() h.update(bytearray(b'foo')) h.update(memoryview(b'baz')) self.assertEqual( '21eb6533733a5e4763acacd1d45a60c2e0e404e1', h.hexdigest() ) h = self.hasher(bytearray(b'foo')) h.update(b'baz') self.assertEqual( '21eb6533733a5e4763acacd1d45a60c2e0e404e1', h.hexdigest() ) h = self.hasher(memoryview(b'foo')) h.update(b'baz') self.assertEqual( '21eb6533733a5e4763acacd1d45a60c2e0e404e1', h.hexdigest() ) class hashlibtests(unittest.TestCase, hashertestsbase): hasher = hashlib.sha1 if sha1dc: class sha1dctests(unittest.TestCase, hashertestsbase): hasher = sha1dc.sha1 if __name__ == '__main__': silenttestrunner.main(__name__)