Mercurial > hg
view tests/test-hg-parseurl.py @ 45825:8f07f5a9c3de
worker: raise exception instead of calling sys.exit() with child's code
When a worker process returns an error code, we would call
`sys.exit()` with that exit code on the main process. The `SystemExit`
exception would then get caught in `scmutil.callcatch()`, which would
return that error code. The comment there says "Commands shouldn't
sys.exit directly", which I agree with. This patch changes it so we
raise a specific exception when a worker fails so we can catch
instead. I think that means that `SystemExit` is now always an
internal error.
(I had earlier thought that this call to `sys.exit()` was from within
the child process until Matt Harbison made me look again, so thanks
for that!)
Differential Revision: https://phab.mercurial-scm.org/D9287
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Sat, 07 Nov 2020 21:50:28 -0800 |
parents | 2372284d9457 |
children | 4452cb788404 |
line wrap: on
line source
from __future__ import absolute_import, print_function import unittest from mercurial import hg class ParseRequestTests(unittest.TestCase): def testparse(self): self.assertEqual( hg.parseurl(b'http://example.com/no/anchor'), (b'http://example.com/no/anchor', (None, [])), ) self.assertEqual( hg.parseurl(b'http://example.com/an/anchor#foo'), (b'http://example.com/an/anchor', (b'foo', [])), ) self.assertEqual( hg.parseurl(b'http://example.com/no/anchor/branches', [b'foo']), (b'http://example.com/no/anchor/branches', (None, [b'foo'])), ) self.assertEqual( hg.parseurl(b'http://example.com/an/anchor/branches#bar', [b'foo']), (b'http://example.com/an/anchor/branches', (b'bar', [b'foo'])), ) self.assertEqual( hg.parseurl( b'http://example.com/an/anchor/branches-None#foo', None ), (b'http://example.com/an/anchor/branches-None', (b'foo', [])), ) self.assertEqual( hg.parseurl(b'http://example.com/'), (b'http://example.com/', (None, [])), ) self.assertEqual( hg.parseurl(b'http://example.com'), (b'http://example.com/', (None, [])), ) self.assertEqual( hg.parseurl(b'http://example.com#foo'), (b'http://example.com/', (b'foo', [])), ) if __name__ == '__main__': import silenttestrunner silenttestrunner.main(__name__)