view hgeditor @ 49534:92892dff03f3

revlog: use the user facing filename as the display_id for filelogs

I had trouble isolating some LFS blob corruption detected by `hg verify` because
the traceback referenced a file, but with the `data/` prefix in the `.hg/store`
path, so it couldn't be located with the `file()` revset:

```
    Traceback (most recent call last):
      File "/mnt/d/mercurial/mercurial/revlog.py", line 3209, in verifyintegrity
        _verify_revision(self, skipflags, state, node)
      File "/mnt/d/mercurial/hgext/lfs/wrapper.py", line 246, in _verify_revision
        orig(rl, skipflags, state, node)
      File "/mnt/d/mercurial/mercurial/revlog.py", line 158, in _verify_revision
        rl.revision(node)
      File "/mnt/d/mercurial/mercurial/revlog.py", line 1816, in revision
        return self._revisiondata(nodeorrev, _df)
      File "/mnt/d/mercurial/mercurial/revlog.py", line 1870, in _revisiondata
        self.checkhash(text, node, rev=rev)
      File "/mnt/d/mercurial/mercurial/revlog.py", line 1996, in checkhash
        % (self.display_id, pycompat.bytestr(revornode))
    mercurial.error.RevlogError: integrity check failed on data/EXE/PPC/shrinksrec.exe:0
```

(I'm a little surprised it resulted in a stacktrace instead of just a message,
but that's a different issue.  I'm also not sure how to trigger the simplestore
case, since IIUC, it's also a revlog based store.)

It's not clear how to handle the changelog and manifest (because the user
doesn't interact with them as a file), so those cases are left alone.  The other
thing that would be nice to improve somehow is to indicate that the ":0" is a
revlog revision, not the changeset revision that users are used to.  I'm not
sure how to handle the "or node" part though.

#!/bin/sh
#
# This is an example of using HGEDITOR to create of diff to review the
# changes while committing.

# If you want to pass your favourite editor some other parameters
# only for Mercurial, modify this:
case "${EDITOR}" in
    "")
        EDITOR="vi"
        ;;
    emacs)
        EDITOR="$EDITOR -nw"
        ;;
    gvim|vim)
        EDITOR="$EDITOR -f -o"
        ;;
esac


HGTMP=""
cleanup_exit() {
    rm -rf "$HGTMP"
}

# Remove temporary files even if we get interrupted
trap "cleanup_exit" 0 # normal exit
trap "exit 255" HUP INT QUIT ABRT TERM

HGTMP=$(mktemp -d ${TMPDIR-/tmp}/hgeditor.XXXXXX)
[ x$HGTMP != x -a -d $HGTMP ] || {
  echo "Could not create temporary directory! Exiting." 1>&2
  exit 1
}

(
    grep '^HG: changed' "$1" | cut -b 13- | while read changed; do
        "$HG" diff "$changed" >> "$HGTMP/diff"
    done
)

cat "$1" > "$HGTMP/msg"

MD5=$(which md5sum 2>/dev/null) || \
    MD5=$(which md5 2>/dev/null)
[ -x "${MD5}" ] && CHECKSUM=`${MD5} "$HGTMP/msg"`
if [ -s "$HGTMP/diff" ]; then
    $EDITOR "$HGTMP/msg" "$HGTMP/diff" || exit $?
else
    $EDITOR "$HGTMP/msg" || exit $?
fi
[ -x "${MD5}" ] && (echo "$CHECKSUM" | ${MD5} -c >/dev/null 2>&1 && exit 13)

mv "$HGTMP/msg" "$1"

exit $?