Mercurial > hg
view contrib/plan9/mkfile @ 51723:9367571fea21
cext: correct the argument handling of `b85encode()`
The type stub indicated that this argument is `Optional`, which implies None is
allowed. I don't see in the documentation where that's the case for `i`[1], and
trying it in `hg debugshell` resulted in the method failing with a TypeError. I
guess it was typed as an `int` argument because the `p` format unit wasn't added
until Python 3.3[2].
In any event, 2 clients in core (`pvec` and `obsolete`) call this with no
argument supplied, and `mdiff` calls it with True. So I guess we've avoided the
None arg case, and when no arg is supplied, it defaults to the 0 initialization
of the `pad` variable in C. Since the `p` format unit accepts both `int` and
None, as well as `bool`, I'm not bothering to bump the module version- this code
is more permissive than it was, in addition to being more correct.
Interestingly, when I first imported the `cext` and `pure` methods in the same
manner as the previous commit, it dropped the `Optional` part of the argument
type when generating `util.pyi`. No idea why.
[1] https://docs.python.org/3/c-api/arg.html#numbers
[2] https://docs.python.org/3/c-api/arg.html#other-objects
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Sat, 20 Jul 2024 01:55:09 -0400 |
parents | f9262456fb01 |
children |
line wrap: on
line source
APE=/sys/src/ape <$APE/config PYTHON=python PYTHONBIN=/rc/bin SH=ape/psh PURE=--pure ROOT=../.. # This is slightly underhanded; Plan 9 does not support GNU gettext nor # does it support dynamically loaded extension modules. We work around # this by calling build_py and build_scripts directly; this avoids # additional platform hacks in setup.py. build:VQ: @{ cd $ROOT $SH -c '$PYTHON setup.py $PURE build_py build_scripts' } clean:VQ: @{ cd $ROOT $SH -c '$PYTHON setup.py $PURE clean --all' } install:VQ: build @{ cd $ROOT $SH -c '$PYTHON setup.py $PURE install \ --install-scripts $PYTHONBIN \ --skip-build \ --force' } mkdir -p /lib/mercurial/hgrc.d dircp hgrc.d /lib/mercurial/hgrc.d/ cp 9diff /rc/bin/