Mercurial > hg
view mercurial/testing/__init__.py @ 51723:9367571fea21
cext: correct the argument handling of `b85encode()`
The type stub indicated that this argument is `Optional`, which implies None is
allowed. I don't see in the documentation where that's the case for `i`[1], and
trying it in `hg debugshell` resulted in the method failing with a TypeError. I
guess it was typed as an `int` argument because the `p` format unit wasn't added
until Python 3.3[2].
In any event, 2 clients in core (`pvec` and `obsolete`) call this with no
argument supplied, and `mdiff` calls it with True. So I guess we've avoided the
None arg case, and when no arg is supplied, it defaults to the 0 initialization
of the `pad` variable in C. Since the `p` format unit accepts both `int` and
None, as well as `bool`, I'm not bothering to bump the module version- this code
is more permissive than it was, in addition to being more correct.
Interestingly, when I first imported the `cext` and `pure` methods in the same
manner as the previous commit, it dropped the `Optional` part of the argument
type when generating `util.pyi`. No idea why.
[1] https://docs.python.org/3/c-api/arg.html#numbers
[2] https://docs.python.org/3/c-api/arg.html#other-objects
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Sat, 20 Jul 2024 01:55:09 -0400 |
parents | 8e0d823ef182 |
children | f4733654f144 |
line wrap: on
line source
import os import time # work around check-code complains # # This is a simple log level module doing simple test related work, we can't # import more things, and we do not need it. environ = getattr(os, 'environ') def wait_on_cfg(ui, cfg, timeout=10): """synchronize on the `cfg` config path Use this to synchronize commands during race tests. """ full_config = b'sync.' + cfg wait_config = full_config + b'-timeout' sync_path = ui.config(b'devel', full_config) if sync_path is not None: timeout = ui.config(b'devel', wait_config) ready_path = sync_path + b'.waiting' write_file(ready_path) wait_file(sync_path, timeout=timeout) def _timeout_factor(): """return the current modification to timeout""" default = int(environ.get('HGTEST_TIMEOUT_DEFAULT', 360)) current = int(environ.get('HGTEST_TIMEOUT', default)) if current == 0: return 1 return current / float(default) def wait_file(path, timeout=10): timeout *= _timeout_factor() start = time.time() while not os.path.exists(path): if timeout and time.time() - start > timeout: raise RuntimeError(b"timed out waiting for file: %s" % path) time.sleep(0.01) def write_file(path, content=b''): if content: write_path = b'%s.tmp' % path else: write_path = path with open(write_path, 'wb') as f: f.write(content) if path != write_path: os.rename(write_path, path)