Mercurial > hg
view relnotes/6.6 @ 51723:9367571fea21
cext: correct the argument handling of `b85encode()`
The type stub indicated that this argument is `Optional`, which implies None is
allowed. I don't see in the documentation where that's the case for `i`[1], and
trying it in `hg debugshell` resulted in the method failing with a TypeError. I
guess it was typed as an `int` argument because the `p` format unit wasn't added
until Python 3.3[2].
In any event, 2 clients in core (`pvec` and `obsolete`) call this with no
argument supplied, and `mdiff` calls it with True. So I guess we've avoided the
None arg case, and when no arg is supplied, it defaults to the 0 initialization
of the `pad` variable in C. Since the `p` format unit accepts both `int` and
None, as well as `bool`, I'm not bothering to bump the module version- this code
is more permissive than it was, in addition to being more correct.
Interestingly, when I first imported the `cext` and `pure` methods in the same
manner as the previous commit, it dropped the `Optional` part of the argument
type when generating `util.pyi`. No idea why.
[1] https://docs.python.org/3/c-api/arg.html#numbers
[2] https://docs.python.org/3/c-api/arg.html#other-objects
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Sat, 20 Jul 2024 01:55:09 -0400 |
parents | 3fd1efb3ad12 |
children |
line wrap: on
line source
= Mercurial 6.6.3 = * tests: don't use "status" operand of dd in test-censor.t (issue6858) * tests: make sha256line.py available for all tests * tests: use sha256line.py instead of /dev/random in test-censor.t (issue6858) * tests: fix nondeterministic test failure in test-contrib-perf.t * rust-changelog: don't panic on empty file lists * grep: restore usage of --include/--exclude options = Mercurial 6.6.2 = * histedit: remove superfluous echo() and endwin() calls (issue6859) * persistent-nodemap: avoid writing nodemap for empty revlog * persistent-nodemap: respect the mmap setting when refreshing data * bundle: do not detect --base argument that match nothing as lack of argument * narrow: prevent removal of ACL-defined excludes * pycompat: fix bytestr(bytes) in Python 3.11 = Mercurial 6.6.1 = The first two patches fix aborted transactions that could happen since 6.6. * revlog: avoid exposing delayed index entry too widely in non-inline revlog * revlog: avoid wrongly updating the data file location on "divert" * tests: do not fail tests in a state with uncommitted .py file removal * perf-tags: fix the --clear-fnode-cache-rev code * perf-tags: fix clear_cache_fnodes to actually clear that cache * censor: fix things around inlining * Various Python 3 cleanups * Various Windows test suite fixes = Mercurial 6.6 = As usual, a *lot* of patches don't make it to this list. == New Features == * rust-config: add support for default config items * rhg: add config defaults to configitems.toml * rhg: support "status FILE" * rhg: support rhg files [FILE] * commands: add admin namespace * admin-command: add verify command * debug-delta-chain: add options to control what we compute * Added some caching for uncompressed revlog chunks that speed up some operations == New Experimental Features == == Bug Fixes == * Improve OpenVMS support * byteify-strings: passe sysstr to attr function and wrapper * journal: track bookmark deletion * transaction: actually delete file created during the transaction on rollback * pull: avoid referencing a variable before it is initialized * rust-filepatterns: also normalize RelPath * narrow: hoist a variable to a higher level to avoid use-before-init warning * convert: stabilize subversion date sorter * run-tests: detect HGWITHRUSTEXT value * censor: accept censored revision during upgrade * rust-matchers: fix quadratic complexity in `FileMatcher` * unstable: do not consider internal phases when computing unstable * Still a whole bunch of Python 2 -> 3 migration leftovers == Backwards Compatibility Changes == * perf: display all timing by default * infinitepush: drop the extension * debug-delta-chain: print less data by default == Internal API Changes == * The revlog interface has been significantly cleaned up. * configitems: add `documentation` field * configitems: declare items in a TOML file * configitems: move blackbox's config items to the new configitems.toml * path-suboption: deprecated specifying the attributes as bytes * pycompat: deprecate using bytes * check-code: drop the `safehasattr` rule * safehasattr: drop usage in favor of hasattr * rust: add `UncheckedRevision` type * rust: implement the `Graph` trait for all revlogs * rust: make `Revision` a newtype * perf: change the way we approach revlog reading * perf: ensure all readlog's reading is done within a `reading` context * delta-chain: move the debugdeltachain command in revlogutils == Miscellaneous ==