Mercurial > hg
view contrib/vagrant/Vagrantfile @ 31471:95be8b7181d3
osutil: fix potential wrong fd close
According to POSIX closedir [1]:
If a file descriptor is used to implement type DIR, that file descriptor
shall be closed.
According to POSIX fdopendir [2]:
Upon calling closedir() the file descriptor shall be closed.
So we should avoid "close(dfd)" after "closedir(dir)". With threads, there
could be a race where an innocent fd gets closed. But Python GIL seems to
help hiding the issue well.
[1]: http://pubs.opengroup.org/onlinepubs/009695399/functions/closedir.html
[2]: http://pubs.opengroup.org/onlinepubs/9699919799/functions/fdopendir.html
author | Jun Wu <quark@fb.com> |
---|---|
date | Wed, 15 Mar 2017 20:43:12 -0700 |
parents | a31ffc445f02 |
children | 7fd16ddabaa0 |
line wrap: on
line source
# -*- mode: ruby -*- Vagrant.configure('2') do |config| # Debian 8.1 x86_64 without configuration management software config.vm.box = "debian/jessie64" config.vm.hostname = "tests" config.vm.define "tests" do |conf| conf.vm.provision :file, source: "run-tests.sh", destination:"run-tests.sh" conf.vm.provision :shell, path: "provision.sh" conf.vm.synced_folder "../..", "/hgshared" end end