view tests/test-inotify-issue1371.t @ 18759:9baf4330d88f

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.
author Durham Goode <durham@fb.com>
date Fri, 08 Mar 2013 16:59:36 -0800
parents f58175f409b0
children
line wrap: on
line source


  $ "$TESTDIR/hghave" inotify || exit 80
  $ hg init
  $ touch a b c d e f
  $ echo "[extensions]" >> $HGRCPATH
  $ echo "inotify=" >> $HGRCPATH

inserve

  $ hg inserve -d --pid-file=hg.pid 2>&1
  $ cat hg.pid >> "$DAEMON_PIDS"
  $ hg ci -Am m
  adding a
  adding b
  adding c
  adding d
  adding e
  adding f
  adding hg.pid

let the daemon finish its stuff

  $ sleep 1

eed to test all file operations

  $ hg rm a
  $ rm b
  $ echo c >> c
  $ touch g
  $ hg add g
  $ hg mv e h
  $ hg status
  M c
  A g
  A h
  R a
  R e
  ! b
  $ sleep 1

Are we able to kill the service? if not, the service died on some error

  $ "$TESTDIR/killdaemons.py" hg.pid