Mercurial > hg
view tests/test-unionrepo.t @ 26750:9f9ec4abe700
cmdutil: make in-memory changes visible to external editor (issue4378)
Before this patch, external editor process for the commit log can't
view some in-memory changes (especially, of dirstate), because they
aren't written out until the end of transaction (or wlock).
This causes unexpected output of Mercurial commands spawned from that
editor process.
To make in-memory changes visible to external editor process, this
patch does:
- write (or schedule to write) in-memory dirstate changes, and
- set HG_PENDING environment variable, if:
- a transaction is running, and
- there are in-memory changes to be visible
"hg diff" spawned from external editor process for "hg qrefresh"
shows:
- "changes newly imported into the topmost" before 49148d7868df(*)
- "all changes recorded in the topmost by refreshing" after this patch
(*) 49148d7868df changed steps invoking editor process
Even though backward compatibility may be broken, the latter behavior
looks reasonable, because "hg diff" spawned from the editor process
consistently shows "what changes new revision records" regardless of
invocation context.
In fact, issue4378 itself should be resolved by 800e090e9c64, which
made 'repo.transaction()' write in-memory dirstate changes out
explicitly before starting transaction. It also made "hg qrefresh"
imply 'dirstate.write()' before external editor invocation in call
chain below.
- mq.queue.refresh
- strip.strip
- repair.strip
- localrepository.transaction
- dirstate.write
- localrepository.commit
- invoke external editor
Though, this patch has '(issue4378)' in own summary line to indicate
that issues like issue4378 should be fixed by this.
BTW, this patch adds '-m' option to a 'hg ci --amend' execution in
'test-commit-amend.t', to avoid invoking external editor process.
In this case, "unsure" states may be changed to "clean" according to
timestamp or so on. These changes should be written into pending file,
if external editor invocation is required,
Then, writing dirstate changes out breaks stability of test, because
it shows "transaction abort!/rollback completed" occasionally.
Aborting after editor process invocation while commands below may
cause similar instability of tests, too (AFAIK, there is no more such
one, at this revision)
- commit --amend
- without --message/--logfile
- import
- without --message/--logfile,
- without --no-commit,
- without --bypass,
- one of below, and
- patch has no description text, or
- with --edit
- aborting at the 1st patch, which adds or removes file(s)
- if it only changes existing files, status is checked only for
changed files by 'scmutil.matchfiles()', and transition from
"unsure" to "normal" in dirstate doesn't occur (= dirstate
isn't changed, and written out)
- aborting at the 2nd or later patch implies other pending
changes (e.g. changelog), and always causes showing
"transaction abort!/rollback completed"
author | FUJIWARA Katsunori <foozy@lares.dti.ne.jp> |
---|---|
date | Sat, 17 Oct 2015 01:15:34 +0900 |
parents | 198b003a2263 |
children | bf86e3e87123 |
line wrap: on
line source
Test unionrepo functionality Create one repository $ hg init repo1 $ cd repo1 $ touch repo1-0 $ echo repo1-0 > f $ hg ci -Aqmrepo1-0 $ touch repo1-1 $ echo repo1-1 >> f $ hg ci -Aqmrepo1-1 $ touch repo1-2 $ echo repo1-2 >> f $ hg ci -Aqmrepo1-2 $ hg log --template '{rev}:{node|short} {desc|firstline}\n' 2:68c0685446a3 repo1-2 1:8a58db72e69d repo1-1 0:f093fec0529b repo1-0 $ tip1=`hg id -q` $ cd .. - and a clone with a not-completely-trivial history $ hg clone -q repo1 --rev 0 repo2 $ cd repo2 $ touch repo2-1 $ sed '1i\ > repo2-1 at top > ' f > f.tmp $ mv f.tmp f $ hg ci -Aqmrepo2-1 $ touch repo2-2 $ hg pull -q ../repo1 -r 1 $ hg merge -q $ hg ci -Aqmrepo2-2-merge $ touch repo2-3 $ echo repo2-3 >> f $ hg ci -mrepo2-3 $ hg log --template '{rev}:{node|short} {desc|firstline}\n' 4:2f0d178c469c repo2-3 3:9e6fb3e0b9da repo2-2-merge 2:8a58db72e69d repo1-1 1:c337dba826e7 repo2-1 0:f093fec0529b repo1-0 $ cd .. revisions from repo2 appear as appended / pulled to repo1 $ hg -R union:repo1+repo2 log --template '{rev}:{node|short} {desc|firstline}\n' 5:2f0d178c469c repo2-3 4:9e6fb3e0b9da repo2-2-merge 3:c337dba826e7 repo2-1 2:68c0685446a3 repo1-2 1:8a58db72e69d repo1-1 0:f093fec0529b repo1-0 manifest can be retrieved for revisions in both repos $ hg -R union:repo1+repo2 mani -r $tip1 f repo1-0 repo1-1 repo1-2 $ hg -R union:repo1+repo2 mani -r 4 f repo1-0 repo1-1 repo2-1 repo2-2 files can be retrieved form both repos $ hg -R repo1 cat repo1/f -r2 repo1-0 repo1-1 repo1-2 $ hg -R union:repo1+repo2 cat -r$tip1 repo1/f repo1-0 repo1-1 repo1-2 $ hg -R union:repo1+repo2 cat -r4 $TESTTMP/repo1/f repo2-1 at top repo1-0 repo1-1 files can be compared across repos $ hg -R union:repo1+repo2 diff -r$tip1 -rtip diff -r 68c0685446a3 -r 2f0d178c469c f --- a/f Thu Jan 01 00:00:00 1970 +0000 +++ b/f Thu Jan 01 00:00:00 1970 +0000 @@ -1,3 +1,4 @@ +repo2-1 at top repo1-0 repo1-1 -repo1-2 +repo2-3 heads from both repos are found correctly $ hg -R union:repo1+repo2 heads --template '{rev}:{node|short} {desc|firstline}\n' 5:2f0d178c469c repo2-3 2:68c0685446a3 repo1-2 revsets works across repos $ hg -R union:repo1+repo2 id -r "ancestor($tip1, 5)" 8a58db72e69d annotate works - an indication that linkrevs works $ hg --cwd repo1 -Runion:../repo2 annotate $TESTTMP/repo1/f -r tip 3: repo2-1 at top 0: repo1-0 1: repo1-1 5: repo2-3 union repos can be cloned ... and clones works correctly $ hg clone -U union:repo1+repo2 repo3 requesting all changes adding changesets adding manifests adding file changes added 6 changesets with 11 changes to 6 files (+1 heads) $ hg -R repo3 paths default = union:repo1+repo2 $ hg -R repo3 verify checking changesets checking manifests crosschecking files in changesets and manifests checking files 6 files, 6 changesets, 11 total revisions $ hg -R repo3 heads --template '{rev}:{node|short} {desc|firstline}\n' 5:2f0d178c469c repo2-3 2:68c0685446a3 repo1-2 $ hg -R repo3 log --template '{rev}:{node|short} {desc|firstline}\n' 5:2f0d178c469c repo2-3 4:9e6fb3e0b9da repo2-2-merge 3:c337dba826e7 repo2-1 2:68c0685446a3 repo1-2 1:8a58db72e69d repo1-1 0:f093fec0529b repo1-0