view tests/test-hgweb-head.t @ 51756:a53162bd73ed

subrepo: drop the default value of None for the archive matcher

This was flagged by pytype after adding hints to `match.subdirmatcher` that it
takes a non-optional matcher.  That matcher argument is used without a guard in
the subdirmatcher constructor, so that's the correct restriction.

I don't think this fixes a bug in practice because the only way these are
invoked is either by a parent `hgsubrepo.archive()`, `archival.archive()`, or
the largefiles override of these.  The `hgsubrepo.archive()` case (and the
largefiles override) uses what the caller provided, so the caller will
eventually be `archival.archive()` (or the largfiles override) up the call
chain.  The `archival.archive()` method also has None for its matcher's default
arg.  However, the three callers of that (`commands.archive()`,
`webcommands.archive()`, and `extdiff.snapshot()`) all provide a matcher
argument, so the None case can never occur unless a 3rd party extension swaps it
for None.  Sadly, we can't make the argument on the `archival.archive()`
non-optional because there is a kwarg prior to it.

Even though the largefiles override of `archival.archive()` is provided a valid
matcher, we duplicate the internal creation of the matcher that the original
`archival.archive()` does for consistency.  By eliminating an impossible to hit
case, we can simplify some of the subrepo code too, by dropping unreachable
code.

#require serve

Some tests for hgweb responding to HEAD requests

  $ hg init test
  $ cd test
  $ mkdir da
  $ echo foo > da/foo
  $ echo foo > foo
  $ hg ci -Ambase
  adding da/foo
  adding foo
  $ hg bookmark -r0 '@'
  $ hg bookmark -r0 'a b c'
  $ hg bookmark -r0 'd/e/f'
  $ hg serve -n test -p $HGPORT -d --pid-file=hg.pid -A access.log -E errors.log
  $ cat hg.pid >> $DAEMON_PIDS

manifest

  $ get-with-headers.py localhost:$HGPORT --method=HEAD 'file/tip/?style=raw' - date etag server
  200 Script output follows
  content-type: text/plain; charset=ascii
  
  $ get-with-headers.py localhost:$HGPORT --method=HEAD 'file/tip/da?style=raw' - date etag server
  200 Script output follows
  content-type: text/plain; charset=ascii
  

plain file

  $ get-with-headers.py localhost:$HGPORT --method=HEAD 'file/tip/foo?style=raw' - date etag server
  200 Script output follows
  content-disposition: inline; filename="foo"
  content-length: 4
  content-type: application/binary
  

should give a 404 - static file that does not exist

  $ get-with-headers.py localhost:$HGPORT --method=HEAD 'static/bogus' - date etag server
  404 Not Found
  content-type: text/html; charset=ascii
  
  [1]

should give a 404 - bad revision

  $ get-with-headers.py localhost:$HGPORT --method=HEAD 'file/spam/foo?style=raw' - date etag server
  404 Not Found
  content-type: text/plain; charset=ascii
  
  [1]

should give a 400 - bad command

  $ get-with-headers.py localhost:$HGPORT --method=HEAD 'file/tip/foo?cmd=spam&style=raw' - date etag server
  400* (glob)
  content-type: text/plain; charset=ascii
  
  [1]

should give a 404 - file does not exist

  $ get-with-headers.py localhost:$HGPORT --method=HEAD 'file/tip/bork?style=raw' - date etag server
  404 Not Found
  content-type: text/plain; charset=ascii
  
  [1]

try bad style

  $ get-with-headers.py localhost:$HGPORT --method=HEAD 'file/tip/?style=foobar' - date etag server
  200 Script output follows
  content-type: text/html; charset=ascii
  

log

  $ get-with-headers.py localhost:$HGPORT --method=HEAD 'log?style=raw' - date etag server
  200 Script output follows
  content-type: text/plain; charset=ascii
  

access bookmarks

  $ get-with-headers.py localhost:$HGPORT --method=HEAD 'rev/@?style=paper' - date etag server
  200 Script output follows
  content-type: text/html; charset=ascii
  

static file

  $ get-with-headers.py localhost:$HGPORT --method=HEAD 'static/style-gitweb.css' - date etag server
  200 Script output follows
  content-length: 9074
  content-type: text/css
  

  $ killdaemons.py

  $ cd ..