Mercurial > hg
view tests/binfile.bin @ 27933:a6833e464b07 stable
run-tests: "fix" race condition in race condition fix
Laurent's commit 3203dfe341f9 still suffers from a race: by the
time the "job" function tries to assign to channels[channel], that
list has been truncated to empty. The result is that every job
thread raises an IndexError.
Earlier, I tried an approach of correctly locking channels, but
that caused run-tests to hang on KeyboardInterrupt sometimes.
This approach is strictly hackier, but seems to actually work
reliably.
author | Bryan O'Sullivan <bryano@fb.com> |
---|---|
date | Fri, 22 Jan 2016 11:00:13 -0800 |
parents | 751df21dad72 |
children |