view CONTRIBUTING @ 44219:aab70b540d3d stable

resourceutil: account for the non-resource-like file hierarchy under py2exe

After 9e367157a990, config files for py2exe were expected to be in
C:\Program Files\Mercurial\mercurial\defaultrc because of the implied resource
structure of 'mercurial.defaultrc.*.rc', relative to the executable.
Accomodating this would require changes to the WIX and Inno scripts (and perhaps
the script that generates the WIX script), as well as 3rd party bundlers like
TortoiseHg.  But these files aren't read as resources anyway- they fall back to
the filesystem APIs.  (If we really wanted to carry on the charade, the
installer would have to also sprinkle various empty __init__.py files around.)

Instead, this simply prunes the 'mercurial.' portion of the resource name when
run with py2exe.  (PyOxidizer uses the resources API, not the filesystem
fallback, so it is unaffected.)  Since this hack only affects the py2 Windows
installers and is less risky, I think it's reasonable.  We haven't needed to
load any 3rd party resource up to this point, and would have to make packaging
changes anyway to handle that.

Differential Revision: https://phab.mercurial-scm.org/D8058

Our full contribution guidelines are in our wiki, please see:

https://www.mercurial-scm.org/wiki/ContributingChanges

If you just want a checklist to follow, you can go straight to

https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist

If you can't run the entire testsuite for some reason (it can be
difficult on Windows), please at least run `contrib/check-code.py` on
any files you've modified and run `python contrib/check-commit` on any
commits you've made (for example, `python contrib/check-commit
273ce12ad8f1` will report some style violations on a very old commit).