view tests/test-abort-checkin.t @ 51885:adbb183c2f27

vfs: simplify the `abstractvfs.rename()` implementation

PyCharm was yapping about `util.rename()` not returning anything, because it is
typed to return `None`, but the value was captured and returned after calling
`_avoidambig()`.  Instead, drop all of that, unconditionally rename, and then
call `_avoidambig()` if appropriate.

While we're here, convert the ersatz ternary operator into a modern one to help
pytype.  When a variable is initialized the old way, pytype tends to assign the
type of the LHS of the `and`.  In this case, that's a bool, and it will get
confused that bool doesn't have a `stat` attribute once this method gets more
type annotations.  (Currently it thinks the `checkambig` arg is `Any`, so it
doesn't care.)

  $ cat > abortcommit.py <<EOF
  > from mercurial import error
  > def hook(**args):
  >     raise error.Abort(b"no commits allowed")
  > def reposetup(ui, repo):
  >     repo.ui.setconfig(b"hooks", b"pretxncommit.nocommits", hook)
  > EOF
  $ abspath=`pwd`/abortcommit.py

  $ cat <<EOF >> $HGRCPATH
  > [extensions]
  > mq =
  > abortcommit = $abspath
  > EOF

  $ hg init foo
  $ cd foo
  $ echo foo > foo
  $ hg add foo

mq may keep a reference to the repository so __del__ will not be
called and .hg/journal.dirstate will not be deleted:

  $ hg ci -m foo
  error: pretxncommit.nocommits hook failed: no commits allowed
  transaction abort!
  rollback completed
  abort: no commits allowed
  [255]
  $ hg ci -m foo
  error: pretxncommit.nocommits hook failed: no commits allowed
  transaction abort!
  rollback completed
  abort: no commits allowed
  [255]

  $ cd ..