view CONTRIBUTING @ 37208:b9dd8403d8ff

zope: force module import by importing symbols

Previously, we tried to import a module and handle the ImportError.
Our lazy module importer doesn't verify the module exists and returns
a dummy object representing the module. Only once we attempt to load
a symbol in the module does the ImportError get raises.

This means that simple imports inside `try..except ImportError` don't
detect missing modules.

This commit changes imports in zope.interface to access symbols, thus
forcing module load and triggering ImportError.

This fixes zope.interface for pure builds.

Differential Revision: https://phab.mercurial-scm.org/D2980

Our full contribution guidelines are in our wiki, please see:

https://www.mercurial-scm.org/wiki/ContributingChanges

If you just want a checklist to follow, you can go straight to

https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist

If you can't run the entire testsuite for some reason (it can be
difficult on Windows), please at least run `contrib/check-code.py` on
any files you've modified and run `python contrib/check-commit` on any
commits you've made (for example, `python contrib/check-commit
273ce12ad8f1` will report some style violations on a very old commit).