Mercurial > hg
view tests/test-revert-interactive-curses.t @ 51930:bc9ed92d4753
util: make `mmapread()` work on Windows again
522b4d729e89 started referencing `mmap.MAP_PRIVATE`, but that's not available on
Windows, so `hg version` worked, but `make local` did not. That commit also
started calling the constructor with the fine-grained `flags` and `prot` args,
but those aren't available on Windows either[1] (though the backing C code
doesn't seem conditionalized to disallow usage of them).
I assume the change away from from the `access` arg was to provide the same
options, plus `MAP_POPULATE`. Looking at the source code[2], they're not quite
the same- `ACCESS_READ` is equivalent to `flags = MAP_SHARED` and `prot = PROT_READ`.
`MAP_PRIVATE` is only used with `ACCESS_COPY`, which allows read and write.
Therefore, we can't quite get the same baseline flags on Windows, but this was
the status quo ante and `MAP_POPULATE` is a Linux thing, so presumably it works.
I realize that typically the OS differences are abstracted into the platform
modules, but I'm leaving it here so that it is obvious what the differences are
between the platforms.
[1] https://docs.python.org/3/library/mmap.html#mmap.mmap
[2] https://github.com/python/cpython/blob/5e0abb47886bc665eefdcc19fde985f803e49d4c/Modules/mmapmodule.c#L1539
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Tue, 01 Oct 2024 15:00:39 -0400 |
parents | 079197e94b24 |
children |
line wrap: on
line source
#require curses #testcases committed wdir Revert interactive tests with the Curses interface $ cat <<EOF >> $HGRCPATH > [ui] > interactive = true > interface = curses > [experimental] > crecordtest = testModeCommands > EOF TODO: Make a curses version of the other tests from test-revert-interactive.t. #if committed $ maybe_commit() { > hg ci "$@" > } $ do_revert() { > hg revert -ir'.^' > } #else $ maybe_commit() { > true > } $ do_revert() { > hg revert -i > } #endif When a line without EOL is selected during "revert -i" $ hg init $TESTTMP/revert-i-curses-eol $ cd $TESTTMP/revert-i-curses-eol $ echo 0 > a $ hg ci -qAm 0 $ printf 1 >> a $ maybe_commit -qAm 1 $ cat a 0 1 (no-eol) $ cat <<EOF >testModeCommands > c > EOF $ do_revert reverting a $ cat a 0 When a selected line is reverted to have no EOL $ hg init $TESTTMP/revert-i-curses-eol2 $ cd $TESTTMP/revert-i-curses-eol2 $ printf 0 > a $ hg ci -qAm 0 $ echo 0 > a $ maybe_commit -qAm 1 $ cat a 0 $ cat <<EOF >testModeCommands > c > EOF $ do_revert reverting a $ cat a 0 (no-eol)