view tests/test-add.t @ 43198:c16fe77e340a

pathcopies: give up any optimization based on `introrev`

Between 8a0136f69027 and d98fb3f42f33, we sped up the search for the
introduction revision during path copies. However, further checking show that
finding the introduction revision is still expensive and that we are better off
without it. So we simply drop it and only rely on the linkrev optimisation.

I ran `perfpathcopies` on 6989 pair of revision in the pypy
repository (`hg perfhelper-pathcopies`. The result is massively in favor of
dropping this condition. The result of the copy tracing are unchanged.

Attempt to use a smaller changes preserving linkrev usage were unsuccessful, it
can return wrong result. The following changesets broke test-mv-cp-st-diff.t

    -        if not f.isintroducedafter(limit):
    +        if limit >= 0 and f.linkrev() < limit:
                 return None


Here are various numbers (before this changeset/after this changesets)

            source       destination  before      after    saved-time  ratio
worth cases e66f24650daf 695dfb0f493b 1.062843 1.246369 -0.183526 1.172675
            c979853a3b6a 8d60fe293e79 1.036985 1.196414 -0.159429 1.153743
            22349fa2fc33 fbb1c9fd86c0 0.879926 1.038682 -0.158756 1.180420
            682b98f3e672 a4878080a536 0.909952 1.063801 -0.153849 1.169074
            5adabc9b9848 920958a93997 0.993622 1.147452 -0.153830 1.154817
worse  1%   dbfbfcf077e9 aea8f2fd3593 1.016595 1.082999 -0.066404 1.065320
worse  5%   c95f1ced15f2 7d29d5e39734 0.453694 0.471156 -0.017462 1.038488
worse 10%   3e144ed1d5b7 2aef0e942480 0.035140 0.037535 -0.002395 1.068156
worse 25%   321fc60db035 801748ba582a 0.009267 0.009325 -0.000058 1.006259
median      2088ce763fc2 e6991321d78b 0.000665 0.000651 0.000014 0.978947
best 25%    915631a97de6 385b31354be6 0.040743 0.040363 0.000380 0.990673
best 10%    ad495c36a765 19c10384d3e7 0.431658 0.411490 0.020168 0.953278
best  5%    d13ae7d283ae 813c99f810ac 1.141404 1.075346 0.066058 0.942126
best  1%    81593cb4a496 99ae11866969 1.833297 0.063823 1.769474 0.034813
best cases  c3b14617fbd7 743a0fcaa4eb 1101.811740 2.735970 1099.075770 0.002483
            c3b14617fbd7 9ba6ab77fd29 1116.753953 2.800729 1113.953224 0.002508
            058b99d6e81f 57e249b7a3ea 1246.128485 3.042762 1243.085723 0.002442
            9a8c361aab49 0354a250d371 1253.111894 3.085796 1250.026098 0.002463
            442dbbc53c68 3ec1002a818c 1261.786294 3.138607 1258.647687 0.002487


As one can see, the average case is not really impacted. However, the worth case
we get after this changeset are much better than the one we had before it. We
have 30 pairs where improvements are above 10 minutes.

This reflect in the combined time for all pairs
before: 26256s
after:   1300s (-95%)

If we remove these pathological 30 cases, we still see a significant improvements:
before:  1631s
after:   1245s (-24%)

  $ hg init a
  $ cd a
  $ echo a > a
  $ hg add -n
  adding a
  $ hg st
  ? a
  $ hg add
  adding a
  $ hg st
  A a
  $ hg forget a
  $ hg add
  adding a
  $ hg forget a
  $ hg add --color debug
  [ui.addremove.added ui.status|adding a]
  $ hg st
  A a
  $ mkdir dir
  $ cd dir
  $ hg add ../a
  ../a already tracked!
  $ cd ..

  $ echo b > b
  $ hg add -n b
  $ hg st
  A a
  ? b
  $ hg add b
  $ hg st
  A a
  A b

should fail

  $ hg add b
  b already tracked!
  $ hg st
  A a
  A b

#if no-windows
  $ echo foo > con.xml
  $ hg --config ui.portablefilenames=jump add con.xml
  abort: ui.portablefilenames value is invalid ('jump')
  [255]
  $ hg --config ui.portablefilenames=abort add con.xml
  abort: filename contains 'con', which is reserved on Windows: con.xml
  [255]
  $ hg st
  A a
  A b
  ? con.xml
  $ hg add con.xml
  warning: filename contains 'con', which is reserved on Windows: con.xml
  $ hg st
  A a
  A b
  A con.xml
  $ hg forget con.xml
  $ rm con.xml
#endif

#if eol-in-paths
  $ echo bla > 'hello:world'
  $ hg --config ui.portablefilenames=abort add
  adding hello:world
  abort: filename contains ':', which is reserved on Windows: 'hello:world'
  [255]
  $ hg st
  A a
  A b
  ? hello:world
  $ hg --config ui.portablefilenames=ignore add
  adding hello:world
  $ hg st
  A a
  A b
  A hello:world
#endif

  $ hg ci -m 0 --traceback

  $ hg log -r "heads(. or wdir() & file('**'))"
  changeset:   0:* (glob)
  tag:         tip
  user:        test
  date:        Thu Jan 01 00:00:00 1970 +0000
  summary:     0
  
should fail

  $ hg add a
  a already tracked!

  $ echo aa > a
  $ hg ci -m 1
  $ hg up 0
  1 files updated, 0 files merged, 0 files removed, 0 files unresolved
  $ echo aaa > a
  $ hg ci -m 2
  created new head

  $ hg merge
  merging a
  warning: conflicts while merging a! (edit, then use 'hg resolve --mark')
  0 files updated, 0 files merged, 0 files removed, 1 files unresolved
  use 'hg resolve' to retry unresolved file merges or 'hg merge --abort' to abandon
  [1]
  $ hg st
  M a
  ? a.orig

wdir doesn't cause a crash, and can be dynamically selected if dirty

  $ hg log -r "heads(. or wdir() & file('**'))"
  changeset:   2147483647:ffffffffffff
  parent:      2:* (glob)
  parent:      1:* (glob)
  user:        test
  date:        * (glob)
  
should fail

  $ hg add a
  a already tracked!
  $ hg st
  M a
  ? a.orig
  $ hg resolve -m a
  (no more unresolved files)
  $ hg ci -m merge

Issue683: peculiarity with hg revert of an removed then added file

  $ hg forget a
  $ hg add a
  $ hg st
  ? a.orig
  $ hg rm a
  $ hg st
  R a
  ? a.orig
  $ echo a > a
  $ hg add a
  $ hg st
  M a
  ? a.orig

excluded file shouldn't be added even if it is explicitly specified

  $ hg add a.orig -X '*.orig'
  $ hg st
  M a
  ? a.orig

Forgotten file can be added back (as either clean or modified)

  $ hg forget b
  $ hg add b
  $ hg st -A b
  C b
  $ hg forget b
  $ echo modified > b
  $ hg add b
  $ hg st -A b
  M b
  $ hg revert -qC b

  $ hg add c && echo "unexpected addition of missing file"
  c: * (glob)
  [1]
  $ echo c > c
  $ hg add d c && echo "unexpected addition of missing file"
  d: * (glob)
  [1]
  $ hg st
  M a
  A c
  ? a.orig
  $ hg up -C
  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

forget and get should have the right order: added but missing dir should be
forgotten before file with same name is added

  $ echo file d > d
  $ hg add d
  $ hg ci -md
  $ hg rm d
  $ mkdir d
  $ echo a > d/a
  $ hg add d/a
  $ rm -r d
  $ hg up -C
  1 files updated, 0 files merged, 0 files removed, 0 files unresolved
  $ cat d
  file d

Test that adding a directory doesn't require case matching (issue4578)
#if icasefs
  $ mkdir -p CapsDir1/CapsDir
  $ echo abc > CapsDir1/CapsDir/AbC.txt
  $ mkdir CapsDir1/CapsDir/SubDir
  $ echo def > CapsDir1/CapsDir/SubDir/Def.txt

  $ hg add capsdir1/capsdir
  adding CapsDir1/CapsDir/AbC.txt
  adding CapsDir1/CapsDir/SubDir/Def.txt

  $ hg forget capsdir1/capsdir/abc.txt

  $ hg forget capsdir1/capsdir
  removing CapsDir1/CapsDir/SubDir/Def.txt

  $ hg add capsdir1
  adding CapsDir1/CapsDir/AbC.txt
  adding CapsDir1/CapsDir/SubDir/Def.txt

  $ hg ci -m "AbCDef" capsdir1/capsdir

  $ hg status -A capsdir1/capsdir
  C CapsDir1/CapsDir/AbC.txt
  C CapsDir1/CapsDir/SubDir/Def.txt

  $ hg files capsdir1/capsdir
  CapsDir1/CapsDir/AbC.txt
  CapsDir1/CapsDir/SubDir/Def.txt

  $ echo xyz > CapsDir1/CapsDir/SubDir/Def.txt
  $ hg ci -m xyz capsdir1/capsdir/subdir/def.txt

  $ hg revert -r '.^' capsdir1/capsdir
  reverting CapsDir1/CapsDir/SubDir/Def.txt

The conditional tests above mean the hash on the diff line differs on Windows
and OS X
  $ hg diff capsdir1/capsdir
  diff -r * CapsDir1/CapsDir/SubDir/Def.txt (glob)
  --- a/CapsDir1/CapsDir/SubDir/Def.txt	Thu Jan 01 00:00:00 1970 +0000
  +++ b/CapsDir1/CapsDir/SubDir/Def.txt	* (glob)
  @@ -1,1 +1,1 @@
  -xyz
  +def

  $ hg mv CapsDir1/CapsDir/abc.txt CapsDir1/CapsDir/ABC.txt
  $ hg ci -m "case changing rename" CapsDir1/CapsDir/AbC.txt CapsDir1/CapsDir/ABC.txt

  $ hg status -A capsdir1/capsdir
  M CapsDir1/CapsDir/SubDir/Def.txt
  C CapsDir1/CapsDir/ABC.txt

  $ hg remove -f 'glob:**.txt' -X capsdir1/capsdir
  $ hg remove -f 'glob:**.txt' -I capsdir1/capsdir
  removing CapsDir1/CapsDir/ABC.txt
  removing CapsDir1/CapsDir/SubDir/Def.txt
#endif

  $ cd ..

test --dry-run mode in forget

  $ hg init testdir_forget
  $ cd testdir_forget
  $ echo foo > foo
  $ hg add foo
  $ hg commit -m "foo"
  $ hg forget foo --dry-run -v
  removing foo
  $ hg diff
  $ hg forget not_exist -n
  not_exist: $ENOENT$
  [1]

  $ cd ..

test --interactive mode in forget

  $ hg init interactiveforget
  $ cd interactiveforget
  $ echo foo > foo
  $ hg commit -qAm "foo"
  $ echo bar > bar
  $ hg commit -qAm "bar"
  $ hg forget foo --dry-run -i
  abort: cannot specify both --dry-run and --interactive
  [255]

  $ hg forget foo --config ui.interactive=True -i << EOF
  > ?
  > n
  > EOF
  forget foo [Ynsa?] ?
  y - yes, forget this file
  n - no, skip this file
  s - skip remaining files
  a - include all remaining files
  ? - ? (display help)
  forget foo [Ynsa?] n

  $ hg forget foo bar --config ui.interactive=True -i << EOF
  > y
  > n
  > EOF
  forget bar [Ynsa?] y
  forget foo [Ynsa?] n
  removing bar
  $ hg status
  R bar
  $ hg up -qC .

  $ hg forget foo bar --config ui.interactive=True -i << EOF
  > s
  > EOF
  forget bar [Ynsa?] s
  $ hg st
  $ hg up -qC .

  $ hg forget foo bar --config ui.interactive=True -i << EOF
  > a
  > EOF
  forget bar [Ynsa?] a
  removing bar
  removing foo
  $ hg status
  R bar
  R foo
  $ hg up -qC .

  $ cd ..