Mercurial > hg
view tests/test-patchbomb-bookmark.t @ 39569:cc23c09bc562
util: optimize cost auditing on insert
Calling popoldest() on insert with cost auditing enabled introduces
significant overhead.
The primary reason for this overhead is that popoldest() needs to
walk the linked list to find the first non-empty node. When we
call popoldest() within a loop, this can become quadratic. The
performance impact is more pronounced on caches with large capacities.
This commit effectively inlines the popoldest() call into
_enforcecostlimit(). By doing so, we only do the backwards walk
to find the first empty node once. However, we still may still
perform this work on insert when the cache is near cost capacity.
So this is only a partial performance win.
$ hg perflrucachedict --size 4 --gets 1000000 --sets 1000000 --mixed 1000000 --costlimit 100
! gets w/ cost limit
! wall 0.598737 comb 0.590000 user 0.590000 sys 0.000000 (best of 17)
! inserts w/ cost limit
! wall 1.694282 comb 1.700000 user 1.700000 sys 0.000000 (best of 6)
! wall 1.659181 comb 1.650000 user 1.650000 sys 0.000000 (best of 7)
! mixed w/ cost limit
! wall 1.157655 comb 1.150000 user 1.150000 sys 0.000000 (best of 9)
! wall 1.139955 comb 1.140000 user 1.140000 sys 0.000000 (best of 9)
$ hg perflrucachedict --size 1000 --gets 1000000 --sets 1000000 --mixed 1000000 --costlimit 10000
! gets w/ cost limit
! wall 0.598526 comb 0.600000 user 0.600000 sys 0.000000 (best of 17)
! wall 0.601993 comb 0.600000 user 0.600000 sys 0.000000 (best of 17)
! inserts w/ cost limit
! wall 37.838315 comb 37.840000 user 37.840000 sys 0.000000 (best of 3)
! wall 25.105273 comb 25.080000 user 25.080000 sys 0.000000 (best of 3)
! mixed w/ cost limit
! wall 18.060198 comb 18.060000 user 18.060000 sys 0.000000 (best of 3)
! wall 12.104470 comb 12.070000 user 12.070000 sys 0.000000 (best of 3)
$ hg perflrucachedict --size 1000 --gets 1000000 --sets 1000000 --mixed 1000000 --costlimit 10000 --mixedgetfreq 90
! gets w/ cost limit
! wall 0.600024 comb 0.600000 user 0.600000 sys 0.000000 (best of 17)
! wall 0.614439 comb 0.620000 user 0.620000 sys 0.000000 (best of 17)
! inserts w/ cost limit
! wall 37.154547 comb 37.120000 user 37.120000 sys 0.000000 (best of 3)
! wall 25.963028 comb 25.960000 user 25.960000 sys 0.000000 (best of 3)
! mixed w/ cost limit
! wall 4.381602 comb 4.380000 user 4.370000 sys 0.010000 (best of 3)
! wall 3.174256 comb 3.170000 user 3.170000 sys 0.000000 (best of 4)
Differential Revision: https://phab.mercurial-scm.org/D4504
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Thu, 06 Sep 2018 12:40:30 -0700 |
parents | d7007b807fa2 |
children |
line wrap: on
line source
Create @ bookmark as main reference $ hg init repo $ cd repo $ echo "[extensions]" >> $HGRCPATH $ echo "patchbomb=" >> $HGRCPATH $ hg book @ Create a dummy revision that must never be exported $ echo no > no $ hg ci -Amno -d '6 0' adding no Create a feature and use -B $ hg book booktest $ echo first > a $ hg ci -Amfirst -d '7 0' adding a $ echo second > b $ hg ci -Amsecond -d '8 0' adding b $ hg email --date '1981-1-1 0:1' -n -t foo -s bookmark -B booktest From [test]: test this patch series consists of 2 patches. Write the introductory message for the patch series. Cc: displaying [PATCH 0 of 2] bookmark ... MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: [PATCH 0 of 2] bookmark Message-Id: <patchbomb.347155260@test-hostname> User-Agent: Mercurial-patchbomb/* (glob) Date: Thu, 01 Jan 1981 00:01:00 +0000 From: test To: foo displaying [PATCH 1 of 2] first ... MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: [PATCH 1 of 2] first X-Mercurial-Node: accde9b8b6dce861c185d0825c1affc09a79cb26 X-Mercurial-Series-Index: 1 X-Mercurial-Series-Total: 2 Message-Id: <accde9b8b6dce861c185.347155261@test-hostname> X-Mercurial-Series-Id: <accde9b8b6dce861c185.347155261@test-hostname> In-Reply-To: <patchbomb.347155260@test-hostname> References: <patchbomb.347155260@test-hostname> User-Agent: Mercurial-patchbomb/* (glob) Date: Thu, 01 Jan 1981 00:01:01 +0000 From: test To: foo # HG changeset patch # User test # Date 7 0 # Thu Jan 01 00:00:07 1970 +0000 # Node ID accde9b8b6dce861c185d0825c1affc09a79cb26 # Parent 043bd3889e5aaf7d88fe3713cf425f782ad2fb71 first diff -r 043bd3889e5a -r accde9b8b6dc a --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/a Thu Jan 01 00:00:07 1970 +0000 @@ -0,0 +1,1 @@ +first displaying [PATCH 2 of 2] second ... MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: [PATCH 2 of 2] second X-Mercurial-Node: 417defd1559c396ba06a44dce8dc1c2d2d653f3f X-Mercurial-Series-Index: 2 X-Mercurial-Series-Total: 2 Message-Id: <417defd1559c396ba06a.347155262@test-hostname> X-Mercurial-Series-Id: <accde9b8b6dce861c185.347155261@test-hostname> In-Reply-To: <patchbomb.347155260@test-hostname> References: <patchbomb.347155260@test-hostname> User-Agent: Mercurial-patchbomb/* (glob) Date: Thu, 01 Jan 1981 00:01:02 +0000 From: test To: foo # HG changeset patch # User test # Date 8 0 # Thu Jan 01 00:00:08 1970 +0000 # Node ID 417defd1559c396ba06a44dce8dc1c2d2d653f3f # Parent accde9b8b6dce861c185d0825c1affc09a79cb26 second diff -r accde9b8b6dc -r 417defd1559c b --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/b Thu Jan 01 00:00:08 1970 +0000 @@ -0,0 +1,1 @@ +second Do the same and combine with -o only one must be exported $ cd .. $ hg clone repo repo2 updating to bookmark @ 1 files updated, 0 files merged, 0 files removed, 0 files unresolved $ cd repo $ hg up @ 0 files updated, 0 files merged, 2 files removed, 0 files unresolved (activating bookmark @) $ hg book outgoing $ echo 1 > x $ hg ci -Am1 -d '8 0' adding x created new head $ hg push ../repo2 -B outgoing pushing to ../repo2 searching for changes adding changesets adding manifests adding file changes added 1 changesets with 1 changes to 1 files (+1 heads) exporting bookmark outgoing $ echo 2 > y $ hg ci -Am2 -d '9 0' adding y $ hg email --date '1982-1-1 0:1' -n -t foo -s bookmark -B outgoing -o ../repo2 comparing with ../repo2 From [test]: test this patch series consists of 1 patches. Cc: displaying [PATCH] bookmark ... MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: [PATCH] bookmark X-Mercurial-Node: 8dab2639fd35f1e337ad866c372a5c44f1064e3c X-Mercurial-Series-Index: 1 X-Mercurial-Series-Total: 1 Message-Id: <8dab2639fd35f1e337ad.378691260@test-hostname> X-Mercurial-Series-Id: <8dab2639fd35f1e337ad.378691260@test-hostname> User-Agent: Mercurial-patchbomb/* (glob) Date: Fri, 01 Jan 1982 00:01:00 +0000 From: test To: foo # HG changeset patch # User test # Date 9 0 # Thu Jan 01 00:00:09 1970 +0000 # Node ID 8dab2639fd35f1e337ad866c372a5c44f1064e3c # Parent 0b24b8316483bf30bfc3e4d4168e922b169dbe66 2 diff -r 0b24b8316483 -r 8dab2639fd35 y --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/y Thu Jan 01 00:00:09 1970 +0000 @@ -0,0 +1,1 @@ +2