Mercurial > hg
view tests/test-hashutil.py @ 51871:cfd30df0f8e4
bundlerepo: fix mismatches with repository and revlog classes
Both pytype and PyCharm complained that `write()` and `_write()` in the
bundlephasecache class aren't proper overrides- indeed they seem to be missing
an argument that the base class has.
PyCharm and pytype also complained that the `revlog.revlog` class doesn't have a
`_chunk()` method. That looks like it was moved from revlog to `_InnerRevlog`
back in e8ad6d8de8b8, and wasn't caught because this module wasn't type checked.
However, I couldn't figure out a syntax with `revlog.revlog._inner._chunk(self, rev)`,
as it complained about passing too many args. `bundlerevlog._rawtext()` uses
this `super(...)` style to call the super class, so hopefully that works, even
with the wonky dynamic subclassing. The revlog class needed the `_InnerRevlog`
field typed because it isn't set in the constructor.
Finally, the vfs type hints look broken. This initially failed with:
File "/mnt/c/Users/Matt/hg/mercurial/bundlerepo.py", line 65, in __init__: Function readonlyvfs.__init__ was called with the wrong arguments [wrong-arg-types]
Expected: (self, vfs: mercurial.vfs.vfs)
Actually passed: (self, vfs: Callable)
Called from (traceback):
line 232, in dirlog
line 214, in __init__
I don't see a raw Callable, but I tried changing some of the vfs args to be typed
as `vfsmod.abstractvfs`, but that class doesn't have `options`, so it failed
elsewhere. `readonlyvfs` isn't a subclass of `vfs` (it's a subclass of
`abstractvfs`), so I'm not sure how to handle that. It would be a shame to have
to make a union of vfs subclasses (but not all of them have `options` either).
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Sat, 03 Aug 2024 01:33:13 -0400 |
parents | 642e31cb55f0 |
children |
line wrap: on
line source
# Tests to ensure that sha1dc.sha1 is exactly a drop-in for # hashlib.sha1 for our needs. import hashlib import unittest import silenttestrunner try: from mercurial.thirdparty import sha1dc except ImportError: sha1dc = None class hashertestsbase: def test_basic_hash(self): h = self.hasher() h.update(b'foo') self.assertEqual( '0beec7b5ea3f0fdbc95d0dd47f3c5bc275da8a33', h.hexdigest() ) h.update(b'bar') self.assertEqual( '8843d7f92416211de9ebb963ff4ce28125932878', h.hexdigest() ) def test_copy_hasher(self): h = self.hasher() h.update(b'foo') h2 = h.copy() h.update(b'baz') h2.update(b'bar') self.assertEqual( '21eb6533733a5e4763acacd1d45a60c2e0e404e1', h.hexdigest() ) self.assertEqual( '8843d7f92416211de9ebb963ff4ce28125932878', h2.hexdigest() ) def test_init_hasher(self): h = self.hasher(b'initial string') self.assertEqual( b'\xc9y|n\x1f3S\xa4:\xbaJ\xca,\xc1\x1a\x9e\xb8\xd8\xdd\x86', h.digest(), ) def test_bytes_like_types(self): h = self.hasher() h.update(bytearray(b'foo')) h.update(memoryview(b'baz')) self.assertEqual( '21eb6533733a5e4763acacd1d45a60c2e0e404e1', h.hexdigest() ) h = self.hasher(bytearray(b'foo')) h.update(b'baz') self.assertEqual( '21eb6533733a5e4763acacd1d45a60c2e0e404e1', h.hexdigest() ) h = self.hasher(memoryview(b'foo')) h.update(b'baz') self.assertEqual( '21eb6533733a5e4763acacd1d45a60c2e0e404e1', h.hexdigest() ) class hashlibtests(unittest.TestCase, hashertestsbase): hasher = hashlib.sha1 if sha1dc: class sha1dctests(unittest.TestCase, hashertestsbase): hasher = sha1dc.sha1 if __name__ == '__main__': silenttestrunner.main(__name__)