Mercurial > hg
view tests/test-revert-interactive-curses.t @ 51871:cfd30df0f8e4
bundlerepo: fix mismatches with repository and revlog classes
Both pytype and PyCharm complained that `write()` and `_write()` in the
bundlephasecache class aren't proper overrides- indeed they seem to be missing
an argument that the base class has.
PyCharm and pytype also complained that the `revlog.revlog` class doesn't have a
`_chunk()` method. That looks like it was moved from revlog to `_InnerRevlog`
back in e8ad6d8de8b8, and wasn't caught because this module wasn't type checked.
However, I couldn't figure out a syntax with `revlog.revlog._inner._chunk(self, rev)`,
as it complained about passing too many args. `bundlerevlog._rawtext()` uses
this `super(...)` style to call the super class, so hopefully that works, even
with the wonky dynamic subclassing. The revlog class needed the `_InnerRevlog`
field typed because it isn't set in the constructor.
Finally, the vfs type hints look broken. This initially failed with:
File "/mnt/c/Users/Matt/hg/mercurial/bundlerepo.py", line 65, in __init__: Function readonlyvfs.__init__ was called with the wrong arguments [wrong-arg-types]
Expected: (self, vfs: mercurial.vfs.vfs)
Actually passed: (self, vfs: Callable)
Called from (traceback):
line 232, in dirlog
line 214, in __init__
I don't see a raw Callable, but I tried changing some of the vfs args to be typed
as `vfsmod.abstractvfs`, but that class doesn't have `options`, so it failed
elsewhere. `readonlyvfs` isn't a subclass of `vfs` (it's a subclass of
`abstractvfs`), so I'm not sure how to handle that. It would be a shame to have
to make a union of vfs subclasses (but not all of them have `options` either).
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Sat, 03 Aug 2024 01:33:13 -0400 |
parents | 079197e94b24 |
children |
line wrap: on
line source
#require curses #testcases committed wdir Revert interactive tests with the Curses interface $ cat <<EOF >> $HGRCPATH > [ui] > interactive = true > interface = curses > [experimental] > crecordtest = testModeCommands > EOF TODO: Make a curses version of the other tests from test-revert-interactive.t. #if committed $ maybe_commit() { > hg ci "$@" > } $ do_revert() { > hg revert -ir'.^' > } #else $ maybe_commit() { > true > } $ do_revert() { > hg revert -i > } #endif When a line without EOL is selected during "revert -i" $ hg init $TESTTMP/revert-i-curses-eol $ cd $TESTTMP/revert-i-curses-eol $ echo 0 > a $ hg ci -qAm 0 $ printf 1 >> a $ maybe_commit -qAm 1 $ cat a 0 1 (no-eol) $ cat <<EOF >testModeCommands > c > EOF $ do_revert reverting a $ cat a 0 When a selected line is reverted to have no EOL $ hg init $TESTTMP/revert-i-curses-eol2 $ cd $TESTTMP/revert-i-curses-eol2 $ printf 0 > a $ hg ci -qAm 0 $ echo 0 > a $ maybe_commit -qAm 1 $ cat a 0 $ cat <<EOF >testModeCommands > c > EOF $ do_revert reverting a $ cat a 0 (no-eol)