Mercurial > hg
view hgext/git/TODO.md @ 47051:de26b9a7ec29 stable
git: consistently use str for parents when rebuilding the index database
The tests show no changes, but when these values are overwritten shortly after
when a git commit object is available, that uses str. It seems better to use
that for consistency.
It does materially affect the database though, because the old value stored was
`X'3030..3030'` and is now '00..00' when the changelog table is dumped in
sqlite3. There is one query that specifies the parents, but it passes the non
null hashes as str, so it worked as expected. That likely explains the lack of
test changes.
Differential Revision: https://phab.mercurial-scm.org/D10527
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Tue, 27 Apr 2021 18:39:59 -0400 |
parents | c5653cf2811d |
children |
line wrap: on
line source
Octopus Merge Support ===================== This will be moderately complicated, as we'll need to synthesize phony changeset entries to explode the octopus into "revisions" that only have two parents each. For today, we can probably just do something like aaaaaaaaaaaaaaaaaaXX{20 bytes of exploded node's hex sha} where XX is a counter (so we could have as many as 255 parents in a git commit - more than I think we'd ever see.) That means that we can install some check in this extension to disallow checking out or otherwise interacting with the `aaaaaaaaaaaaaaaaaa` revisions. Interface Creation ==================== We at least need an interface definition for `changelog` in core that this extension can satisfy, and again for `basicstore`. Reason About Locking ==================== We should spend some time thinking hard about locking, especially on .git/index etc. We're probably adequately locking the _git_ repository, but may not have enough locking correctness in places where hg does locking that git isn't aware of (notably the working copy, which I believe Git does not lock.)