view tests/test-remotefilelog-keepset.t @ 50671:e06d1a779eb6

store: stop relying on a `revlog_type` property

We want to know if a file is related to a revlog, but the rest is dealt with
differently already, so we simplify things further.

as a bonus, this cleanup This provides a small but noticeable  speedup.

The number below use `hg perf::stream-locked-section` to measure the time spend
in the locked section of the streaming clone. Number are run on various
repository and compare different steps.:

1) the effect of this patchs,
2) the effect of the cleanup series,
2) current state compared to because large refactoring.

All benchmarks are run on linux with Python 3.10.7.


### Effect of this patch
# mercurial-2018-08-01-zstd-sparse-revlog
  # benchmark.name         = perf-stream-locked-section
before:   0.030246 seconds
after:    0.029274 seconds   (-3.21%)
# pypy-2018-08-01-zstd-sparse-revlog
before:   0.545012 seconds
after:    0.520872 seconds   (-4.43%)
# netbeans-2018-08-01-zstd-sparse-revlog
before:   2.719939 seconds
after:    2.626791 seconds   (-3.42%)
# mozilla-central-2018-08-01-zstd-sparse-revlog
before:   6.304179 seconds
after:    6.096700 seconds   (-3.29%)
# mozilla-try-2019-02-18-zstd-sparse-revlog
before:  14.142687 seconds
after:   13.640779 seconds   (-3.55%)

### Effect of this series

A small but sizeable speedup

# mercurial-2018-08-01-zstd-sparse-revlog
before:  0.031122 seconds
after:   0.029274 seconds   (-5.94%)
# pypy-2018-08-01-zstd-sparse-revlog
before:  0.589970 seconds
after:   0.520872 seconds  (-11.71%)
# netbeans-2018-08-01-zstd-sparse-revlog
before:  2.980300 seconds
after:   2.626791 seconds  (-11.86%)
# mozilla-central-2018-08-01-zstd-sparse-revlog
before:  6.863204 seconds
after:   6.096700 seconds  (-11.17%)
# mozilla-try-2019-02-18-zstd-sparse-revlog
before: 14.921393 seconds
after:  13.640779 seconds   (-8.58%)


### Current state compared to the pre-refactoring state

The refactoring introduced multiple string manipulation and dictionary creation
that seems to induce a signifiant slowdown
Slowdown

# mercurial-2018-08-01-zstd-sparse-revlog
6.4.3:  0.019459 seconds
after:  0.029274 seconds  (+50.44%)
## pypy-2018-08-01-zstd-sparse-revlog
6.4.3:  0.290715 seconds
after:  0.520872 seconds  (+79.17%)
# netbeans-2018-08-01-zstd-sparse-revlog
6.4.3:  1.403447 seconds
after:  2.626791 seconds  (+87.17%)
# mozilla-central-2018-08-01-zstd-sparse-revlog
6.4.3:  3.163549 seconds
after:  6.096700 seconds  (+92.72%)
# mozilla-try-2019-02-18-zstd-sparse-revlog
6.4.3:  6.702184 seconds
after: 13.640779 seconds (+103.53%)

#require no-windows

  $ . "$TESTDIR/remotefilelog-library.sh"

  $ hg init master
  $ cd master
  $ cat >> .hg/hgrc <<EOF
  > [remotefilelog]
  > server=True
  > serverexpiration=-1
  > EOF
  $ echo x > x
  $ hg commit -qAm x
  $ echo y > y
  $ hg commit -qAm y
  $ echo z > z
  $ hg commit -qAm z
  $ cd ..

  $ hgcloneshallow ssh://user@dummy/master shallow -q
  3 files fetched over 1 fetches - (3 misses, 0.00% hit ratio) over *s (glob)

# Compute keepset for 0th and 2nd commit, which implies that we do not process
# the 1st commit, therefore we diff 2nd manifest with the 0th manifest and
# populate the keepkeys from the diff
  $ cd shallow
  $ cat >> .hg/hgrc <<EOF
  > [remotefilelog]
  > pullprefetch=0+2
  > EOF
  $ hg debugkeepset

# Compute keepset for all commits, which implies that we only process deltas of
# manifests of commits 1 and 2 and therefore populate the keepkeys from deltas
  $ cat >> .hg/hgrc <<EOF
  > [remotefilelog]
  > pullprefetch=all()
  > EOF
  $ hg debugkeepset