view tests/test-contrib-emacs.t @ 51516:e0f92bd98c24 stable

phases: avoid a potentially costly dictionary interation in some case

If we retract for the draft phase, there is not non-public item to be retracted
and we can skip this part. This part is was apparently super costly thanks to
Python.

On mozilla-try-2019-02-18, a perf::unbundle call with a 10 000 changesets
bundle gives give use the following timing.

e57d4b868a3e:     4.6 seconds
ac1c75188440:   102.5 seconds
this-changeset:  30.0 seconds

So we recovered about ⅔ of the regression, the next changeset will give us the
rest back.

#require emacs
  $ emacs -q -no-site-file -batch -l $TESTDIR/../contrib/hg-test-mode.el \
  >  -f ert-run-tests-batch-and-exit
  Running 1 tests (*) (glob)
     passed  1/1  hg-test-mode--compilation-mode-support* (glob)
  
  Ran 1 tests, 1 results as expected* (glob)