Mercurial > hg
view contrib/lock-checker.py @ 18442:ecba9b0e7672
posix: don't compare atime when determining if a file has changed
A file's atime might change even if the file itself doesn't change. This might
cause us to invalidate caches more often than necessary.
Before this change, hg add often resulted in the dirstate being parsed twice
on systems that track atime. After this change, it is only parsed once. For a
repository with over 180,000 files, this speeds up hg add from 1.2 seconds to
1.0.
author | Siddharth Agarwal <sid0@fb.com> |
---|---|
date | Fri, 18 Jan 2013 15:55:16 -0800 |
parents | b8424c92ba2b |
children | 47d0843647d1 |
line wrap: on
line source
"""Extension to verify locks are obtained in the required places. This works by wrapping functions that should be surrounded by a lock and asserting the lock is held. Missing locks are called out with a traceback printed to stderr. This currently only checks store locks, not working copy locks. """ import os import traceback def _warnstack(ui, msg, skip=1): '''issue warning with the message and the current stack, skipping the skip last entries''' ui.warn('%s at:\n' % msg) entries = traceback.extract_stack()[:-skip] fnmax = max(len(entry[0]) for entry in entries) for fn, ln, func, _text in entries: ui.warn(' %*s:%-4s in %s\n' % (fnmax, fn, ln, func)) def _checklock(repo): l = repo._lockref and repo._lockref() if l is None or not l.held: _warnstack(repo.ui, 'missing lock', skip=2) def reposetup(ui, repo): orig = repo.__class__ class lockcheckrepo(repo.__class__): def _writejournal(self, *args, **kwargs): _checklock(self) return orig._writejournal(self, *args, **kwargs) def transaction(self, *args, **kwargs): _checklock(self) return orig.transaction(self, *args, **kwargs) # TODO(durin42): kiilerix had a commented-out lock check in # _writebranchcache and _writerequirements def _tag(self, *args, **kwargs): _checklock(self) return orig._tag(self, *args, **kwargs) def write(self, *args, **kwargs): assert os.path.lexists(self._join('.hg/wlock')) return orig.write(self, *args, **kwargs) repo.__class__ = lockcheckrepo