Mercurial > hg
view .gitlab/merge_request_templates/Default.md @ 51721:ed28085827ec
typing: explicitly type some `mercurial.util` eol code to avoid @overload
Unlike the previous commit, this makes a material difference in the generated
stub file- the `pycompat.identity()` aliases generated an @overload like this:
@overload
def fromnativeeol(a: _T0) -> _T0: ...
... which might fail to detect a bad argument, like str. This drops the
@overload for the 3 related methods, so there's a single definition for each.
The `typelib.BinaryIO_Proxy` is used for subclassing (the same as was done in
8147abc05794), so that it is a `BinaryIO` type during type checking, but still
inherits `object` at runtime. That way, we don't need to implement unused
abstract methods.
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Fri, 19 Jul 2024 16:49:46 -0400 |
parents | 7b6d3a9bd7be |
children |
line wrap: on
line source
/assign_reviewer @mercurial.review <!-- Welcome to the Mercurial Merge Request creation process: * Set a simple title for your MR, * All important information should be contained in your changesets' content or description, * You can add some workflow-relevant information here (eg: when this depends on another MR), * If your changes are not ready for review yet, click `Start the title with Draft:` under the title. More details here: * https://www.mercurial-scm.org/wiki/ContributingChanges * https://www.mercurial-scm.org/wiki/Heptapod -->