Mercurial > hg
view hgext/narrow/TODO.rst @ 48488:f8540fe4be0f
procutil: avoid an uninitialized variable usage on tempfile exception
If `pycompat.unnamedtempfile()` raises an exception, it would have called
`stdin.close()` in the `finally` block without it being initialized first.
Differential Revision: https://phab.mercurial-scm.org/D11928
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Tue, 14 Dec 2021 17:29:30 -0500 |
parents | ce0bc2952e2a |
children |
line wrap: on
line source
Address commentary in manifest.excludedmanifestrevlog.add - specifically we should improve the collaboration with core so that add() never gets called on an excluded directory and we can improve the stand-in to raise a ProgrammingError. Reason more completely about rename-filtering logic in narrowfilelog. There could be some surprises lurking there. Formally document the narrowspec format. For bonus points, unify with the server-specified narrowspec format. narrowrepo.setnarrowpats() or narrowspec.save() need to make sure they're holding the wlock. The follinwg places do an unrestricted dirstate walk (including files outside the narrowspec). Some of them should perhaps not do that. * debugfileset * perfwalk * sparse (but restricted to sparse config) * largefiles