Mercurial > hg
view tests/test-audit-path.out @ 9116:f90bbf1ea09f
inotify: fix issue1375, add a test.
The biggest problem was the data structure, which did not allow changing
a file into a directory or vice versa. This problem is fixed by b55d44719b47.
The walk() method also had an issue in this case:
- we know 'path' as a directory. inotify server sleeps.
- 'path' is deleted
- 'path' is recreated as a file
- the server catches up here, and see the deletion. it instantiates a scan(),
which in its turn calls for walk(repo, path).
- walk() then assumes that 'path' is a directory and calls os.listdir on it,
which raises an OSError(errno.ENOTDIR)
Catch the error, and yield the file instead of the directory contents.
author | Nicolas Dumazet <nicdumz.commits@gmail.com> |
---|---|
date | Mon, 13 Jul 2009 16:49:05 +0200 |
parents | e9d3a11eacad |
children |
line wrap: on
line source
% should fail abort: path contains illegal component: .hg/00changelog.i adding a/a % should fail abort: path 'b/b' traverses symbolic link 'b' % should succeed % should still fail - maybe abort: path 'b/b' traverses symbolic link 'b' % unbundle tampered bundle adding changesets adding manifests adding file changes added 5 changesets with 6 changes to 6 files (+4 heads) (run 'hg heads' to see heads, 'hg merge' to merge) % attack .hg/test .hg/test abort: path contains illegal component: .hg/test % attack foo/.hg/test foo/.hg/test abort: path 'foo/.hg/test' is inside repo 'foo' % attack back/test where back symlinks to .. back back/test abort: path 'back/test' traverses symbolic link 'back' % attack ../test ../test abort: path contains illegal component: ../test % attack /tmp/test /tmp/test abort: No such file or directory: [HGTMP]/test-audit-path/target//tmp/test