Mercurial > hg
view tests/test-convert-bzr-directories.out @ 9116:f90bbf1ea09f
inotify: fix issue1375, add a test.
The biggest problem was the data structure, which did not allow changing
a file into a directory or vice versa. This problem is fixed by b55d44719b47.
The walk() method also had an issue in this case:
- we know 'path' as a directory. inotify server sleeps.
- 'path' is deleted
- 'path' is recreated as a file
- the server catches up here, and see the deletion. it instantiates a scan(),
which in its turn calls for walk(repo, path).
- walk() then assumes that 'path' is a directory and calls os.listdir on it,
which raises an OSError(errno.ENOTDIR)
Catch the error, and yield the file instead of the directory contents.
author | Nicolas Dumazet <nicdumz.commits@gmail.com> |
---|---|
date | Mon, 13 Jul 2009 16:49:05 +0200 |
parents | 209ef5f3534c |
children |
line wrap: on
line source
% empty directory initializing destination source-hg repository scanning source... sorting... converting... 2 Initial add 1 Empty directory added 0 Added file into directory % manifest of 1 644 a % manifest of tip 644 a 644 empty/something % directory renames tpyo => typo initializing destination source-hg repository scanning source... sorting... converting... 1 Added directory 0 Oops, typo % manifest of 0 644 tpyo/something % manifest of tip 644 typo/something % nested directory renames firstlevel/secondlevel => secondlevel initializing destination source-hg repository scanning source... sorting... converting... 1 Added nested directories 0 Moved secondlevel one level up % manifest of tip 644 secondlevel/file 644 secondlevel/thirdlevel/stuff % directory remove initializing destination source-hg repository scanning source... sorting... converting... 1 Added directory 0 Removed directory % manifest of 0 644 src/sourcecode % manifest of tip % directory replace first/file => second/file first => third initializing destination source-hg repository scanning source... sorting... converting... 1 Initial layout 0 Some conflicting moves % manifest of tip 644 second/file 644 second/something 644 third/dummy