view tests/test-copy.out @ 535:fba26990604a

Deal with failed clone/transaction interaction

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Deal with failed clone/transaction interaction

> What is happening is that something in the transaction machinery is
> causing the directory to be completely recreated.

The transaction gets rolled back by its destructor. This is critical
so it happens whenever an exception occurs that unwinds the stack.

Unfortunately, what's happening with clone is we're trying to delete
the directory during exception propagation. And a reference to the
transaction is held in the exception backtrace stack frames so it
still exists until the exception is completely resolved.

So there's no way to do the directory delete inside the exception
handling cleanly.

But we can handle it similarly to the transaction itself: use an
object with a destructor.

manifest hash: fc38550a20d64d08333f256bbedc312493c1390b
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCxDT2ywK+sNU5EO8RAjikAJ0Tej56rAutxQDfYzVbFGtT1sEC5ACgmVds
/fwdQyHn+FwshugqXLemUaM=
=3f78
-----END PGP SIGNATURE-----

+ hg init
+ echo a
+ hg add a
+ hg commit -t 1 -u test -d '0 0'
+ hg status
? .out
+ cp a b
+ hg copy a b
+ hg status
A b
? .out
+ hg -d commit -t 2 -u test -d '0 0'
b
 b: copy a:b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3
+ hg history
changeset:   1:3b5b84850bbed12e8ff8c1b87b32dc93c59ae6d8
tag:         tip
user:        test
date:        Thu Jan  1 00:00:00 1970
summary:     2

changeset:   0:c19d34741b0a4ced8e4ba74bb834597d5193851e
user:        test
date:        Thu Jan  1 00:00:00 1970
summary:     1

+ hg log a
revision:    0:b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3
changeset:   0:c19d34741b0a4ced8e4ba74bb834597d5193851e
user:        test
date:        Thu Jan  1 00:00:00 1970
summary:     1

+ hexdump -C .hg/data/b.d
00000000  75 01 0a 63 6f 70 79 72  65 76 3a 20 62 37 38 39  |u..copyrev: b789|
00000010  66 64 64 39 36 64 63 32  66 33 62 64 32 32 39 63  |fdd96dc2f3bd229c|
00000020  31 64 64 38 65 65 64 66  30 66 63 36 30 65 32 62  |1dd8eedf0fc60e2b|
00000030  36 38 65 33 0a 63 6f 70  79 3a 20 61 0a 01 0a 61  |68e3.copy: a...a|
00000040  0a                                                |.|
00000041
+ hg cat b
+ md5sum bsum
60b725f10c9c85c70d97880dfe8191b3  bsum
+ hg cat a
+ md5sum asum
60b725f10c9c85c70d97880dfe8191b3  asum
+ hg verify
checking changesets
checking manifests
crosschecking files in changesets and manifests
checking files
2 files, 2 changesets, 2 total revisions