view tests/test-merge-prompt.t @ 16506:fc4e0fecf403 stable

patch: fix patch hunk/metdata synchronization (issue3384)

Git patches are parsed in two phases: 1) extract metadata, 2) parse actual
deltas and merge them with the previous metadata. We do this to avoid
dependency issues like "modify a; copy a to b", where "b" must be copied from
the unmodified "a".

Issue3384 is caused by flaky code I wrote to synchronize the patch metadata
with the emitted hunk:

 if (gitpatches and
     (gitpatches[-1][0] == afile or gitpatches[-1][1] == bfile)):
     gp = gitpatches.pop()[2]

With a patch like:

 diff --git a/a b/c
 copy from a
 copy to c
 --- a/a
 +++ b/c
 @@ -1,1 +1,2 @@
  a
 +a
 @@ -2,1 +2,2 @@
  a
 +a
 diff --git a/a b/a
 --- a/a
 +++ b/a
 @@ -1,1 +1,2 @@
  a
 +b

the first hunk of the first block is matched with the metadata for the block
"diff --git a/a b/c", then the second hunk of the first block is matched with
the metadata of the second block "diff --git a/a b/a", because of the "or" in
the code paste above. Turning the "or" into an "and" is not enough as we have
to deal with /dev/null cases for each file.

We I remove this broken piece of code:

 # copy/rename + modify should modify target, not source
 if gp.op in ('COPY', 'DELETE', 'RENAME', 'ADD') or gp.mode:
     afile = bfile

because "afile = bfile" set "afile" to stuff like "b/file" instead of "a/file",
and because this only happens for git patches, which afile/bfile are ignored
anyway by applydiff().

v2:
- Avoid a traceback on git metadata desynchronization

Test for
b5605d88dc27: Make ui.prompt repeat on "unrecognized response" again
 (issue897)

840e2b315c1f: Fix misleading error and prompts during update/merge
 (issue556)

  $ status() {
  >     echo "--- status ---"
  >     hg st -A file1 file2
  >     for file in file1 file2; do
  >         if [ -f $file ]; then
  >             echo "--- $file ---"
  >             cat $file
  >         else
  >             echo "*** $file does not exist"
  >         fi
  >     done
  > }

  $ hg init

  $ echo 1 > file1
  $ echo 2 > file2
  $ hg ci -Am 'added file1 and file2'
  adding file1
  adding file2

  $ hg rm file1
  $ echo changed >> file2
  $ hg ci -m 'removed file1, changed file2'

  $ hg co 0
  2 files updated, 0 files merged, 0 files removed, 0 files unresolved

  $ echo changed >> file1
  $ hg rm file2
  $ hg ci -m 'changed file1, removed file2'
  created new head


Non-interactive merge:

  $ hg merge -y
   local changed file1 which remote deleted
  use (c)hanged version or (d)elete? c
  remote changed file2 which local deleted
  use (c)hanged version or leave (d)eleted? c
  1 files updated, 0 files merged, 0 files removed, 0 files unresolved
  (branch merge, don't forget to commit)

  $ status
  --- status ---
  M file2
  C file1
  --- file1 ---
  1
  changed
  --- file2 ---
  2
  changed


Interactive merge:

  $ hg co -C
  0 files updated, 0 files merged, 1 files removed, 0 files unresolved

  $ hg merge --config ui.interactive=true <<EOF
  > c
  > d
  > EOF
   local changed file1 which remote deleted
  use (c)hanged version or (d)elete? remote changed file2 which local deleted
  use (c)hanged version or leave (d)eleted? 0 files updated, 0 files merged, 0 files removed, 0 files unresolved
  (branch merge, don't forget to commit)

  $ status
  --- status ---
  file2: * (glob)
  C file1
  --- file1 ---
  1
  changed
  *** file2 does not exist


Interactive merge with bad input:

  $ hg co -C
  0 files updated, 0 files merged, 0 files removed, 0 files unresolved

  $ hg merge --config ui.interactive=true <<EOF
  > foo
  > bar
  > d
  > baz
  > c
  > EOF
   local changed file1 which remote deleted
  use (c)hanged version or (d)elete? unrecognized response
   local changed file1 which remote deleted
  use (c)hanged version or (d)elete? unrecognized response
   local changed file1 which remote deleted
  use (c)hanged version or (d)elete? remote changed file2 which local deleted
  use (c)hanged version or leave (d)eleted? unrecognized response
  remote changed file2 which local deleted
  use (c)hanged version or leave (d)eleted? 1 files updated, 0 files merged, 1 files removed, 0 files unresolved
  (branch merge, don't forget to commit)

  $ status
  --- status ---
  M file2
  R file1
  *** file1 does not exist
  --- file2 ---
  2
  changed


Interactive merge with not enough input:

  $ hg co -C
  1 files updated, 0 files merged, 1 files removed, 0 files unresolved

  $ hg merge --config ui.interactive=true <<EOF
  > d
  > EOF
   local changed file1 which remote deleted
  use (c)hanged version or (d)elete? remote changed file2 which local deleted
  use (c)hanged version or leave (d)eleted? abort: response expected
  [255]

  $ status
  --- status ---
  file2: * (glob)
  C file1
  --- file1 ---
  1
  changed
  *** file2 does not exist