Mercurial > hg
view tests/test-gendoc-ro.t @ 33087:fcd1c483f5ea
strip: add a delayedstrip method that works in a transaction
For long, the fact that strip does not work inside a transaction and some
code has to work with both obsstore and fallback to strip lead to duplicated
code like:
with repo.transaction():
....
if obsstore:
obsstore.createmarkers(...)
if not obsstore:
repair.strip(...)
Things get more complex when you want to call something which may call strip
under the hood. Like you cannot simply write:
with repo.transaction():
....
rebasemod.rebase(...) # may call "strip", so this doesn't work
But you do want rebase to run inside a same transaction if possible, so the
code may look like:
with repo.transaction():
....
if obsstore:
rebasemod.rebase(...)
obsstore.createmarkers(...)
if not obsstore:
rebasemod.rebase(...)
repair.strip(...)
That's ugly and error-prone. Ideally it's possible to just write:
with repo.transaction():
rebasemod.rebase(...)
saferemovenodes(...)
This patch is the first step towards that. It adds a "delayedstrip" method
to repair.py which maintains a postclose callback in the transaction object.
author | Jun Wu <quark@fb.com> |
---|---|
date | Sun, 25 Jun 2017 10:38:45 -0700 |
parents | 8346b2f09e79 |
children |
line wrap: on
line source
#require docutils gettext Error: the current ro localization has some rst defects exposed by moving pager to core. These two warnings about references are expected until the localization is corrected. $ $TESTDIR/check-gendoc ro checking for parse errors gendoc.txt:58: (WARNING/2) Inline interpreted text or phrase reference start-string without end-string. gendoc.txt:58: (WARNING/2) Inline interpreted text or phrase reference start-string without end-string.