view .jshintrc @ 36054:fe5c4b795999

test-merge-tools: stabilize for Windows

This masks the Windows argument parsing insanity[1], so it needs a bit of
explanation.  (The security reference in the footnote is probably useful to keep
in mind if we ever whitelist certain in-repo config settings.)

9037c29e9f53 introduced tests that were failing on Windows with an unbalanced
double quote[2].  What ends up happening here is util.shellquote() is double
quoting the file path, but the shell script is placing this ->": "<- right next
to it.  So cmd.exe gets launched with 'lb:base": ""c:\...\f~base.xyz"', which
got interpreted as 'lb:base: "c:\...\f~base.xyz'. If the test is adjusted to
quote like "lb:$labelbase: $base", then MSYS runs interference and strips the
'\' characters.  I was able to get the expected result by dropping the quotes
from '": "', and changing the space to underscore.  But since we need to glob
away the C: part anyway, just glob away the quote and leave the test unchanged.

[1] https://blogs.msdn.microsoft.com/twistylittlepassagesallalike/2011/04/23/everyone-quotes-command-line-arguments-the-wrong-way/
[2] https://buildbot.mercurial-scm.org/builders/Win7%20x86_64%20hg%20tests/builds/441/steps/run-tests.py%20%28python%202.7.13%29/logs/stdio

{
    // Enforcing
    "eqeqeq"        : true,     // true: Require triple equals (===) for comparison
    "forin"         : true,     // true: Require filtering for..in loops with obj.hasOwnProperty()
    "freeze"        : true,     // true: prohibits overwriting prototypes of native objects such as Array, Date etc.
    "nonbsp"        : true,     // true: Prohibit "non-breaking whitespace" characters.
    "undef"         : true,     // true: Require all non-global variables to be declared (prevents global leaks)

    // Environments
    "browser"       : true      // Web Browser (window, document, etc)
}