view tests/filterpyflakes.py @ 51626:865efc020c33 default tip

dirstate: remove the python-side whitelist of allowed matchers

This whitelist is too permissive because it allows matchers that contain
disallowed ones deep inside, for example through `intersectionmatcher`.

It is also too restrictive because it doesn't pass through
some of the matchers we support, such as `patternmatcher`.

It's also unnecessary because unsupported matchers raise
`FallbackError` and we fall back anyway.

Making this change makes more of the tests use rust code path,
and therefore subtly change behavior. For example, rust status
in largefiles repos seems to have strange behavior.

#!/usr/bin/env python3

# Filter output by pyflakes to control which warnings we check


import re
import sys

lines = []
for line in sys.stdin:
    # We blacklist tests that are too noisy for us
    pats = [
        r"undefined name 'WindowsError'",
        r"redefinition of unused '[^']+' from line",
        # for cffi, allow re-exports from pure.*
        r"cffi/[^:]*:.*\bimport \*' used",
        r"cffi/[^:]*:.*\*' imported but unused",
    ]

    keep = True
    for pat in pats:
        if re.search(pat, line):
            keep = False
            break  # pattern matches
    if keep:
        fn = line.split(':', 1)[0]
        with open(fn, 'rb') as f:
            data = f.read()
        if b'no-' b'check-code' in data:
            continue
        lines.append(line)

for line in lines:
    sys.stdout.write(line)
print()