dirstate: use `dirstate.change_files` to scope the change in `amend` This is the way.

dirstate: use the `changing_files` context in the `keyword` demo This is the way.

dirstate: wrap repository change in appropriate context in `test-context` We need the `wlock` (to add files), the `lock` (to commit), a `transaction` (to commit) and a `changing_files` context (to add files). Strictly speaking, we could let the commit take the `lock` and create a `transaction`, but it seems more consistent that way.

dirstate: use wlock and changing_files context in `test-revlog-ancestry` This is the way.

dirstate: use `dirstate.change_files` to scope the change in `revert` This is the way.

dirstate: use `dirstate.change_files` to scope the change in `gpg` This is the way.

dirstate: use `dirstate.change_files` to scope the change in `tag` This is the way.

dirstate: use `dirstate.change_files` to scope the change in `rename` This is the way, unless we are not actually touching the working copy. In such cases we don't need to do something.

dirstate: use `dirstate.change_files` to scope the change in `copy` This is the way, unless we are not actually touching the working copy. In such cases we don't need to do something.

dirstate: use `dirstate.change_files` to scope the change in `remove` This is the way.

dirstate: use `dirstate.change_files` to scope the change in `forget` This is the way.

dirstate: use `dirstate.change_files` to scope the change in `addremove` This is the way.

dirstate: use `dirstate.change_files` to scope the change in `add` This is the way.

commit: use `dirstate.change_files` to scope the associated `addremove` This was significantly more complicated than I expected, because multiple extensions get in the way. I introduced a context that lazily open the transaction and associated context to work around these complication. See the inline documentation for details. Introducing the wrapping transaction remove the need for dirstate-guard (one of the ultimate goal of all this), and slightly affect the result of a `hg rollback` after a `hg commit --addremove`. That last part is deemed fine. It aligns the behavior with what happens after a failed `hg commit --addremove` and nobody should be using `hg rollback` anyway. The small output change in the test come from the different transaction timing and fact the transaction now backup the dirstate before the addremove, which might mean "no file to backup" when the repository starts from an empty state.

commit: move the addremove logic around to make the next changeset clearer Lets do the noise now, without changing any thing. So the new changeset can focus on the actual semantic changes.

largefiles: link the core dirstate._changing context to the lfdirstate one This will be much cleaner and safer to make sure the two dirstates are in sync. This way, the large-files dirstate will simply inherit the state of the main dirstate, so if the core code does the right thing, the large-files code should be right too.