histedit: track short hash instead of changectx object This simplifies set usage and allow us to add a missing revision check in a later commit.

histedit: ensure rules return short hex at all time Handling homogeneous data is both simpler and safer.

histedit-test: test unknown command We had no tested for this case.

histedit-test: test unknown changeset We had no tested for this case.

histedit-test: test malformed line We had not tested for this case.

histedit-test: test that extra revisions are detected We had not tested for this case.

histedit-test: test that missing revisions are detected We had not tested for this case.

histedit: handle multiple spaces between action and hash (issue3893) There is some clue that the previous code intended to handle that but it was actually not the case. As a result action could apply to the empty string '' changeset, leading to the use the current working directory parent in some operations.

http2: sane readline It turns out that it pays off to read more than a byte at a time with a select in between :)

http2: make read use pushchunk/popchunk, eschew itertools The itertools approach was showing up high in the profile output.

http2: track available data as it changes instead of recomputing it With a large amount of available data, this computation can become costly.

histedit-test: rename histedit-revspec into histedit-argument We have no testing for argument. This small file seems perfect once but needs a rename.

histedit-test: remove unnecessary graphlog extension Graphlog is now in core.

histedit-test: drop skip logic for older mercurial version We are shipped in core now.

hgweb: refactor checks for granting and revoking user permissions Provides an entry point for extensions implementing more complex authorization schemes. Original patch proposed by Markus Zapke-Gründemann.

check-code: add check for lock release order

parsers: fix variable declaration position issue

zsh_completion: complete all files for `commit/backout --logfile` Up until now commit/backout `--logfile` option was completed only with *.txt-files. This requirement is a bit too strong (and is nowhere to be stated) so it's better to complete with all files. Stolen from zsh.git repo, c5fce37b changeset by Oliver Kiddle.

transplant: improve documentation

transplant: clarify what --branch do - it has nothing to do with branches --branch specifies heads and has nothing to do with named branches, and it only deals with topological branches to the same extent as all other DAG operations do.

import: inline checkexact function We have a sngle call now, no need to make it a function.

import: factor out checkexact The two calls are strictly identical. We can simply move it after the if/else clause.

amend: fix unlocking order - first lock then wlock

codingstyle: remove trailing spaces in various text files Better do it once than see random changes in diffs later.

tests: run check-code on Python files without .py extension

histedit: move outgoing processing to its own function Every piece of code extracted from the main command is a win. We simplify changeset determination in the process. Parent ceases being a list before becoming a node. We how have a root variable containing a node all the time.

histedit: move all arguments checks to the beginning of the command This changeset move all checks and raises related to arguments validation to the top of the file. This gathers all the logic in one place and clarifies the code doing actual work. This paves the way for splitting this gigantic function in separated functions. A `goal` variable is introduced in the process. It holds the action to be done by this invocation (new, continue or abort). An invalid invocation is found in the process (the new code is a bit stricter).

histedit-test: generalise --commands "-" usage This is simpler than temporary file version. There some minor test changes since commit messages are no longer modifed. There is still some tests using --commands with a real file.

histedit: allow "-" as a command file When "-" is specified as a command file, we read rules from stdin. Alter a single test to demo the behavior, but most of them could benefit from this. There is minor change in test output resulting from the fact we no longer change log messages.

histedit: properly handle --continue on empty fold When all changes from the fold have been dropped, the --continue code was confused. This changeset handles this case. The test for this case existed but was broken.

histedit-test: replace obscure python script by a plain file One of the tests uses a python script to edit the histedit commands on the fly. It was hard to read and likely to break. This is replaced by a plain command file. Doing so made me discover that the python script is incorrect. The "+6" regexp never matched because the revision number is wrong. This error is kept in the replacement for now. Fixing the histedit command triggers a traceback in histedit. A later changeset will fix the error and restore the intended test.

test: improve documentation of some histedit tests Each test section is clearly separated from the others and gains some helpful documentation.