patchbomb: extract 'getpatchmsgs' closure into its own function
Keep marching toward the promised land of simplification!
patchbomb: extract 'makeintro' closure into its own function
Keep marching toward the promised land of simplification!
patchbomb: extract 'getbundlemsgs' closure in its own function
Keep marching toward the promised land of simplification!
patchbomb: extract 'getdescription' closure in its own function
Keep marching toward the promised land of simplification!
patchbomb: extract 'getbundle' closure in its own function
Keep marching toward the promised land of simplification!
patchbomb: extract 'getpatches' closure in its own function
Keep marching toward the promised land of simplification!
patchbomb: extract 'getoutgoing' closure into its own function
The patchbomb command is a gigantic 300 line function full of closures. As a
first step to simplify it in smaller bits, I'm extracting the closures into full
featured functions. The first victim is 'getoutgoing'. It gains a docstring in
the process.
bundle2: handle empty 'b2x:changegroup' value in push and pull
Changeset
e4dc2b0be056 added advertising of supported changegroup version
through the new 'b2x:changegroup' capability. However, this capability is not
new and has been around since 3.1 with an empty value. This makes new clients
unable to push to 3.2 servers through bundle2 as they cannot find a common
changegroup version to use from and empty list.
Treating empty 'b2x:changegroup' value as old client fixes it.
bundle2: drop duplicated definition of 'b2x:exchange'
This bundle2 capability is going to be dynamically computed in 'getrepocaps'. We
do not need to include it in the static value.