run-tests: make it possible to nest conditionals
This is not that hard to implement and makes our life easier on a regular basis.
rust: box ConfigValueParseError to avoid large result types
clippy emits a warning that all the Result types are way too large
because of HgError includes ConfigValueParseError as one of the variants,
so its size is 136 bytes.
By boxing ConfigValueParseError we're hopefully making everything faster
"for free".
delta-find: rename `delta-reuse-policy` to `pulled-delta-reuse-policy`
This make it clearer which type of delta we are talking about.
config-item: declare undeclared path suboption
This should prevent issue like the previous commit.
delta-find: declare the "paths..*:delta-reuse-policy option
While looking into renaming the option I realized it was not declared.
delta-find: adjust the default candidate group chunk size
We move from 10 to 20 as the default as some usage in the wild saw a small
degradation in storage quality when using `10`.
record: extract a closure to the module level
This clean up is almost as gratuituous as this closure was.
record: drop a now useless overlay that grab the lock
Since
28dfb2df4ab9, commit grab the wlock and the extra layer grabing the lock
in record is no longer needed.
We clean up the code to make this simpler (and add a small assert for extra
security against future change).
bundlerepo: fix string interpolation
Matt Harbison is saying we cannot `%s` a type into a byte string and that seems
reasonable.
bundlerepo: apply phase data stored in the bundle instead of assuming `draft`
The phase information contained in the changegroup part and the explicit
`phase-heads` part are now taken in account.
Initial changes and test by Matt Harbison, code rework by Pierre-Yves David.
bundlerepo: handle changegroup induced phase movement in the associated method
These movement comes from handling the changegroup part, so we keeps the code
grouped. This will be important when handling more part (and more changegroup
part in the future)
This induce a small code duplication, but it does not looks terrible.