contrib: fix dirstatenonnormalcheck to work in Python 3
This is a redo of D1963 that has the added benefit of not breaking
Python 2. Oops.
# skip-blame because this is bytes prefixes and a s/iteritems/items/
Differential Revision: https://phab.mercurial-scm.org/D1970
python3: whitelist another 24 passing tests
Differential Revision: https://phab.mercurial-scm.org/D1911
mdiff: use slice instead of index on bytestr when checking single bytes
This is portable to Python 3.
Differential Revision: https://phab.mercurial-scm.org/D1992
obsutil: work around filter() being a generator in Python 3
Differential Revision: https://phab.mercurial-scm.org/D1910
cmdutil: add a kludge to make bytes repr() the same on 2 and 3
This fixes the output formatting problems I see in debugobsolete. I
still am seeing some effectflag differences, which we'll need to
tackle separately.
I'm not in love with this approach. There might be something better we
could do, and I'd love it if someone else wanted to take a run at
this.
Differential Revision: https://phab.mercurial-scm.org/D1909
wireprotoserver: make name part of protocol interface
This is a required part of the interface. Abstract properties must
be defined at type creation time. So we make name a @property.
Differential Revision: https://phab.mercurial-scm.org/D1991
wireprotoserver: make abstractserverproto a proper abstract base class
Plug in the abc module so we can have run-time validation of type
conformance.
Differential Revision: https://phab.mercurial-scm.org/D1990
wireprotoserver: make response handling attributes private
The send* methods are specific to sshserver and aren't part of the
common protocol interface. So rename them accordingly.
The handlers dict is also specific to sshserver and is related to
these methods. So give it the same treatment.
Differential Revision: https://phab.mercurial-scm.org/D1989
wireprotoserver: make some instance attributes private
sshserver attempts to conform to a well-defined interface. The instance
attributes changed as part of this commit don't appear to be part of
that interface. So prefix them with _ to mark them as private.
Differential Revision: https://phab.mercurial-scm.org/D1988
wireprotoserver: remove sshserver.getarg()
AFAICT the last consumer of this helper method was removed by
d054cc5c7737 in 2010.
Differential Revision: https://phab.mercurial-scm.org/D1987