Fri, 14 Aug 2015 12:25:14 +0900 reachableroots: silence warning of implicit integer narrowing issued by clang
Yuya Nishihara <yuya@tcha.org> [Fri, 14 Aug 2015 12:25:14 +0900] rev 26080
reachableroots: silence warning of implicit integer narrowing issued by clang Tested with CFLAGS=-Wshorten-64-to-32 CC=clang which is the default of Mac OS X. Because a valid revnum shouldn't exceed INT_MAX, we don't need long width for large tovisit array.
Fri, 14 Aug 2015 12:22:08 +0900 reachableroots: narrow scope of minidx variable
Yuya Nishihara <yuya@tcha.org> [Fri, 14 Aug 2015 12:22:08 +0900] rev 26079
reachableroots: narrow scope of minidx variable minidx is never used if includepath is false, so let's define it where it is used.
Tue, 25 Aug 2015 15:54:33 -0700 convert: fix syncing deletes from p2 merge commit
Durham Goode <durham@fb.com> [Tue, 25 Aug 2015 15:54:33 -0700] rev 26078
convert: fix syncing deletes from p2 merge commit Recently we fixed converting merges to correctly sync changes from p2. We missed the case of deletes though (so p2 deleted a file that p1 had not yet deleted, and the file does not belong to the source). The fix is to detect when p2 doesn't have the file, so we just sync it as a delete to p1 in the merge. Updated the test, and verified it failed before the fix.
Mon, 24 Aug 2015 22:16:01 -0700 convert: add convert.git.skipsubmodules option
Durham Goode <durham@fb.com> [Mon, 24 Aug 2015 22:16:01 -0700] rev 26077
convert: add convert.git.skipsubmodules option This adds an option to not pull in gitsubmodules during a convert. This is useful when converting large git repositories where gitsubmodules were allowed historically, but are no longer wanted.
Mon, 24 Aug 2015 19:33:36 -0700 paths: move path validation logic to its own function
Durham Goode <durham@fb.com> [Mon, 24 Aug 2015 19:33:36 -0700] rev 26076
paths: move path validation logic to its own function Hard coding the '.hg' path in the paths class made it difficult for the hggit extension to pull from gitrepos. This patch moves the logic out to it's own function so extensions can add additional checks to what is a valid path (i.e. a git repo is valid when hggit is enabled).
Fri, 21 Aug 2015 14:33:51 -0400 parsers: avoid int/unsigned conversions
Augie Fackler <augie@google.com> [Fri, 21 Aug 2015 14:33:51 -0400] rev 26075
parsers: avoid int/unsigned conversions Detected with make local CFLAGS='-Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter' CC=clang
Fri, 21 Aug 2015 14:29:42 -0400 base85: fix comparison of an int and a long
Augie Fackler <augie@google.com> [Fri, 21 Aug 2015 14:29:42 -0400] rev 26074
base85: fix comparison of an int and a long Caught using make local CFLAGS='-Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter' CC=clang
(0) -10000 -3000 -1000 -300 -100 -30 -10 -7 +7 +10 +30 +100 +300 +1000 +3000 +10000 tip