Simon Heimberg <simohe@besonet.ch> [Fri, 14 Feb 2014 00:34:20 +0100] rev 20597
rebase: do not raise an UnboundLocalError when called wrong (
issue4106)
When the base is not found, we should not raise a traceback about a not defined
variable. This hides the real problem: the function rebasenode was (probably)
called wrong.
An AssertionError is raised to highlight that the caller of the function did
something wrong.
An alternative approach is to only assign None to the variable "base" and let
the merge mechanism raise an abort message. This was the behaviour for this
case before
ad9db007656f. But the only known case for this problem is when an
extension calls this function wrong. An AssertionError makes this clearer than
an abort message. When a different case is detected, the behaviour can be
improved then.
Siddharth Agarwal <sid0@fb.com> [Thu, 27 Feb 2014 19:56:36 -0800] rev 20596
exchange: fix docs for pulloperation
'remote' is actually the remote, not the repo one is pulling into. This
confused me quite a bit.
Matt Mackall <mpm@selenic.com> [Thu, 27 Feb 2014 18:57:03 -0600] rev 20595
merge with stable
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 25 Feb 2014 18:45:01 -0800] rev 20594
resolve: use "other" changeset from merge state (
issue4163)
We can use the "other" data from the recorded merge state instead of inferring
what the other could be from working copy parent. This will allow resolve to
fulfil its duty even when the second parent have been dropped.
Most direct benefit is fixing a regression in backout.
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 25 Feb 2014 18:54:47 -0800] rev 20593
merge: add "other" file node in the merge state file
This data is mostly redundant with the "other" changeset node (+ other changeset
file path). However, more data never hurt.
The old format do not store it so this require some dancing to add and remove it
on demand.
Pierre-Yves David <pierre-yves.david@fb.com> [Thu, 27 Feb 2014 14:14:57 -0800] rev 20592
merge: infer the "other" changeset when falling back to v1 format
When we have to fallback to the old version of the file, we infer the
"other" from current working directory parent. The same way it is currently done
in the resolve command. This is know to have shortcoming… but we cannot do
better from the data contained in the old file format. This is actually the
motivation to add this new file format.
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 25 Feb 2014 18:42:11 -0800] rev 20591
merge: record the "other" node in merge state
We need to record the merge we were merging with. This solve multiple
bug with resolve when dropping the second parent after a merge. This
happen a lot when doing special merge (overriding the ancestor).
Backout, shelve, rebase, etc. can takes advantage of it.
This changeset just add the information in the merge state. We'll use it in the
resolve process in a later changeset.
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 25 Feb 2014 18:37:06 -0800] rev 20590
merge: introduce new format for the state file
This new format will allow us to address common bugs while doing special merge
(graft, backout, rebase…) and record user choice during conflict resolution.
The format is open so we can add more record for future usage.
This file still store hexified version of node to help human willing to debug
it by hand. The overhead or oversize are not expected be an issue.
The old format is still used. It will be written to disk along side the newer
format. And at parse time we detect if the data from old version of the
mergestate are different from the one in the new version file. If its the same,
both have most likely be written at the same time and you can trust the extra
data from the new file. If it differs, the old file have been written by an
older version of mercurial that did not knew about the new file. In that case we
use the content of the old file.
Pierre-Yves David <pierre-yves.david@fb.com> [Thu, 27 Feb 2014 12:59:41 -0800] rev 20589
merge: change the merge state serialisation to use a record based logic
The format of the file is unchanged. But we are preparing a new file with a new
format that would be record based. So we change all the read/write logic to
handle a list of record until a very low level. This will allow simple plugging
of the new format in the current code.
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 25 Feb 2014 17:14:49 -0800] rev 20588
merge: move merge state file path into a constant
We are about to change the format. Having the file path in a single place make
it easier to update the filename for the new version.
Lucas Moscovicz <lmoscovicz@fb.com> [Thu, 13 Feb 2014 09:18:16 -0800] rev 20587
revset: changed spanset __add__ implementation to work lazily
$ time hg log -qr "first(0:tip or draft())"
...
real 0m1.032s
user 0m0.841s
sys 0m0.179s
$ time ./hg log -qr "first(0:tip or draft())"
...
real 0m0.378s
user 0m0.291s
sys 0m0.085s
Lucas Moscovicz <lmoscovicz@fb.com> [Thu, 13 Feb 2014 09:00:25 -0800] rev 20586
revset: changed lazyset __add__ implementation to work lazily
Performance Benchmarking:
$ time hg log -qr "first(author(mpm) or branch(default))"
0:
9117c6561b0b
real 0m3.875s
user 0m3.818s
sys 0m0.051s
$ time ./hg log -qr "first(author(mpm) or branch(default))"
0:
9117c6561b0b
real 0m0.213s
user 0m0.174s
sys 0m0.038s
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 25 Feb 2014 10:32:54 -0800] rev 20585
obsstore: add a __len__ method
We can already use "for mark in store:" it make sense to allow
"len(store)" too.
Pierre-Yves David <pierre-yves.david@fb.com> [Tue, 25 Feb 2014 10:21:54 -0800] rev 20584
obsstore: `create` method return True if a marker is actually added
The obsstore method now have a return value. This informs caller about the
actual creation of a new markers. No new markers are created if it would have
been a duplicate.
Matt Mackall <mpm@selenic.com> [Thu, 27 Feb 2014 15:31:44 -0600] rev 20583
merge with crew
Augie Fackler <raf@durin42.com> [Thu, 27 Feb 2014 15:39:07 -0500] rev 20582
help: exclude deprecated extensions in the disabled part of 'help extensions'
Augie Fackler <raf@durin42.com> [Thu, 27 Feb 2014 15:37:04 -0500] rev 20581
test-help.t: add test for 'hg help extensions'
This demonstrates the defect that deprecated extensions show up in the
output. A followup patch will fix this defect.
Matt Mackall <mpm@selenic.com> [Thu, 27 Feb 2014 15:14:37 -0600] rev 20580
ui: fix extra space in username abort
Matt Mackall <mpm@selenic.com> [Thu, 27 Feb 2014 14:58:44 -0600] rev 20579
tests: fix up config --edit breakage
Matt Mackall <mpm@selenic.com> [Thu, 27 Feb 2014 14:48:36 -0600] rev 20578
merge with stable
anuraggoel <anurag.dsps@gmail.com> [Thu, 27 Feb 2014 22:56:42 +0530] rev 20577
coal: hgweb style adds extra blank line in file view (
issue4136)
Now hgweb style='coal' adds no extra blank in file view.
Piotr Klecha <pklecha@forcom.com.pl> [Tue, 25 Feb 2014 21:26:25 +0100] rev 20576
pull: close peer repo on completion (
issue2491) (
issue2797)
When pulling changes from a compressed bundle Mercurial first uncompresses it
to a temporary file in .hg directory. This file will not be deleted unless
the bundlerepo (other) is explicitly closed.
This is similar to cleanup that occurs after incoming.
Paul Boddie <paul@boddie.org.uk> [Thu, 27 Feb 2014 00:24:06 +0100] rev 20575
hgweb: ensure isdirectory is None for repositories, replacing any True value
Until now, repositories did not provide any value for isdirectory in rows
produced for the index output, and thus isdirectory was generally evaluated as
None for each index entry representing a repository.
However, directories (visible when viewed with the descend and collapse
settings enabled) did provide a value of True and this value appeared to
persist in subsequent rows processed by the templater, causing isdirectory
tests in templates to produce incorrect results for index entries appearing
after directories.
This patch asserts the None value for repositories, thus erasing any such
persistent True values.
Matt Mackall <mpm@selenic.com> [Thu, 27 Feb 2014 14:46:29 -0600] rev 20574
ui: suggest config --edit when no username is set
Matt Mackall <mpm@selenic.com> [Thu, 27 Feb 2014 14:01:52 -0600] rev 20573
config: add example config file when -e called with no config
Matt Mackall <mpm@selenic.com> [Thu, 27 Feb 2014 13:46:32 -0600] rev 20572
config: add initial implementation of --edit
This launches the preferred editor on either:
a) the first non-empty user rc file found
b) the first user rc file in the search list
Pierre-Yves David <pierre-yves.david@fb.com> [Wed, 26 Feb 2014 18:56:27 -0800] rev 20571
revert: extract actual revert in its own function
With this small refactoring, the computation of the action to perform and the
actual change to the disk happen in different function. This allows extension to
wrap the later in case of need. The initial motivation is the `remotefilelog`
extension that need to prefetch all the file content to be checked out.
Matt Mackall <mpm@selenic.com> [Thu, 27 Feb 2014 12:42:09 -0600] rev 20570
config: move showconfig code and add config as primary alias
Preparation for adding config --edit to launch an editor
Lucas Moscovicz <lmoscovicz@fb.com> [Wed, 26 Feb 2014 17:15:55 -0800] rev 20569
revset: added _hexlist method to replace _list for %ln
Now %ln expression goes through _hexlist and doesn't do any unnecesary
processing anymore.
Matt Mackall <mpm@selenic.com> [Wed, 26 Feb 2014 17:57:23 -0600] rev 20568
merge with stable
Olle Lundberg <geek@nerd.sh> [Thu, 27 Feb 2014 00:23:21 +0100] rev 20567
localrepo: language and spelling fixes in comment
Lucas Moscovicz <lmoscovicz@fb.com> [Wed, 26 Feb 2014 12:36:36 -0800] rev 20566
revset: added _intlist method to replace _list for %ld
Now %ld expression goes through _intlist and doesn't do any unnecesary
processing anymore.
anuraggoel <anurag.dsps@gmail.com> [Tue, 25 Feb 2014 06:30:21 +0530] rev 20565
purge: avoid duplicate output for --print (
issue4092)
Now "hg purge -p" commands avoids printiing duplication of filenames.
Second patch is the test coverage of first patch which tells that '-p'
does not depend on whether ui.verbose is configured or not,that means it
is independent of '-v'.
Matt Mackall <mpm@selenic.com> [Mon, 24 Feb 2014 18:50:29 -0600] rev 20564
merge with stable
Matt Mackall <mpm@selenic.com> [Mon, 24 Feb 2014 18:49:09 -0600] rev 20563
merge with stable
Matt Mackall <mpm@selenic.com> [Mon, 24 Feb 2014 18:48:48 -0600] rev 20562
merge with i18n
FUJIWARA Katsunori <foozy@lares.dti.ne.jp> [Sun, 23 Feb 2014 18:03:47 +0900] rev 20561
i18n-ja: synchronized with
7b9d66c0e4fa
Wagner Bruna <wbruna@yahoo.com> [Sun, 16 Feb 2014 09:04:49 -0300] rev 20560
i18n-pt_BR: synchronized with
4e41b2fe46cc
Lucas Moscovicz <lmoscovicz@fb.com> [Mon, 24 Feb 2014 09:27:32 -0800] rev 20559
scmutil: changed revrange code not to use append
Removed one call to the append method
anuraggoel <anurag.dsps@gmail.com> [Tue, 25 Feb 2014 04:11:11 +0530] rev 20558
push: provide a hint when no paths in configured (
issue3692)
When user type "hg push" command then this patch helps user by
providing hint if no default path is configured.
Second patch is the test coverage, to test the change behaviour of
first patch.
Mads Kiilerich <madski@unity3d.com> [Mon, 24 Feb 2014 22:42:14 +0100] rev 20557
revlog: introduce commonancestors method for getting all common ancestor heads
Mads Kiilerich <madski@unity3d.com> [Mon, 24 Feb 2014 22:42:14 +0100] rev 20556
localrepo: commit: avoid calling expensive ancestor function when p1 is nullrev
Mads Kiilerich <madski@unity3d.com> [Mon, 24 Feb 2014 22:42:13 +0100] rev 20555
ancestors: remove unnecessary handling of 'left'
If one of the initial nodes also is an ancestor then that most be the only
ancestor. There is no need for additional bookkeeping.
Mads Kiilerich <madski@unity3d.com> [Mon, 24 Feb 2014 22:42:13 +0100] rev 20554
parsers: remove unreachable and invalid code in index_ancestors
The function normally returns a list. Returning a single element instead of a
list with one element would be weird.
Lucas Moscovicz <lmoscovicz@fb.com> [Thu, 13 Feb 2014 14:27:12 -0800] rev 20553
cmdutil: implemented new lazy increasingwindows
Now log can work in a lazy way and get results as soon as they are processed.
Performance Benchmarking:
$ time hg log -l1 -qr "branch(default)"
0:
9117c6561b0b
real 0m2.303s
user 0m2.252s
sys 0m0.048s
$ time ./hg log -l1 -qr "branch(default)"
0:
9117c6561b0b
real 0m0.238s
user 0m0.199s
sys 0m0.037s
Lucas Moscovicz <lmoscovicz@fb.com> [Thu, 20 Feb 2014 10:15:38 -0800] rev 20552
revset: added __nonzero__ method to lazyset
Now it doesn't have to go through all the set and can return lazily as soon as
it finds one element.
Lucas Moscovicz <lmoscovicz@fb.com> [Wed, 12 Feb 2014 15:30:27 -0800] rev 20551
scmutil: changed revrange to return lazysets for new style revsets
When there is an old style revset or both it will still return a baseset. This
may be changed in later patches.
Mads Kiilerich <madski@unity3d.com> [Thu, 20 Feb 2014 02:43:17 +0100] rev 20550
phases: make order of debug output 'removing unknown node' deterministic
Mads Kiilerich <madski@unity3d.com> [Thu, 20 Feb 2014 02:39:01 +0100] rev 20549
comments: fix minor spelling issues found with spell checker
Mads Kiilerich <madski@unity3d.com> [Sat, 15 Feb 2014 01:23:12 +0100] rev 20548
hooks: for python hooks, consistently use __name__ etc as name, not the repr
There is no reason to expose unnecessary Python implementation details and
memory locations, also not in debug mode.
readablefunc was already creating a nice name - we move that functionality
up and reuse it.
We consider having a __call__ and being types.FunctionType sufficiently
similar and unify these two to just using the existing check for __call__.
Mads Kiilerich <madski@unity3d.com> [Sat, 15 Feb 2014 01:23:12 +0100] rev 20547
hooks: move logging of hook name to after we have found the hook
We do not expect the finding process to take a significant amount of time - it
is the execution time of the hook we care about.
Mads Kiilerich <madski@unity3d.com> [Thu, 20 Feb 2014 02:39:01 +0100] rev 20546
rebase: show nice list instead of set repr for 'computed skipped revs' debug
Mads Kiilerich <madski@unity3d.com> [Sat, 15 Feb 2014 01:23:12 +0100] rev 20545
rebase: fix 'rebase onto %d starting from %s' - show root instead of list repr
The debug statement is already in a 'for root in roots' so it was probably the
intention to show root instead of roots. Do that.
Mads Kiilerich <madski@unity3d.com> [Wed, 12 Feb 2014 23:44:30 +0100] rev 20544
log: describe graph symbols in the help
I wondered what 'x' meant and didn't find it described anywhere.
Mads Kiilerich <madski@unity3d.com> [Thu, 20 Feb 2014 02:38:41 +0100] rev 20543
tests: backout
a82de9dc4f77, debugstacktrace is now stable, drop workaround
Mads Kiilerich <madski@unity3d.com> [Thu, 20 Feb 2014 02:38:36 +0100] rev 20542
util: debugstacktrace, flush before and after writing
Close another stream (default stdout, which often is buffered) before writing
to the primary stream (default stderr, which often is unbuffered). The primary
stream is also flushed after writing (in case it is buffered).
This fixes non-deterministic output order, especially on windows.
Siddharth Agarwal <sid0@fb.com> [Wed, 19 Feb 2014 21:32:14 -0800] rev 20541
run-tests.py: work when --with-hg is set to system hg
Previously we'd always assume that --with-hg is a script in a user directory,
and would write out a 'python' symlink to the same location. That didn't work
if --with-hg was set to a system installation of hg, e.g. /usr/bin/hg.
Introduce a TMPBINDIR directory which is used to write out the python symlink.
Lucas Moscovicz <lmoscovicz@fb.com> [Wed, 12 Feb 2014 18:45:49 -0800] rev 20540
revset: added cached generated list on generatorset
This allows to iterate the generatorset more than once.
Sean Farley <sean.michael.farley@gmail.com> [Thu, 20 Feb 2014 00:46:13 -0600] rev 20539
templater: shorten pure integers
Originally, the addition of the 'shorten' template function in
9c6b86dd2ed2
would not consider pure integers for shortening. This patch considers two
simple cases: when the integer starts with zero (which is parsed by Mercurial
as a hash first) and when the integer is larger than the tip (obviously not a
rev).
Lucas Moscovicz <lmoscovicz@fb.com> [Fri, 21 Feb 2014 13:16:17 -0800] rev 20538
revset: fixed bug where log -f was taking too long to return